Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add wait in replica recovery for allocation id to propagate on source… #16097

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Sep 26, 2024

Backport #15786 to 2.x

… node (#15558)

* Add wait for target allocation id to appear

Signed-off-by: Gaurav Bafna <[email protected]>

* making waitForAssignment same

Signed-off-by: Gaurav Bafna <[email protected]>

* Add more test

Signed-off-by: Gaurav Bafna <[email protected]>

---------

Signed-off-by: Gaurav Bafna <[email protected]>
Copy link
Contributor

❌ Gradle check result for df8bce3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for df8bce3: SUCCESS

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.56%. Comparing base (01ea078) to head (df8bce3).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...search/indices/recovery/RecoverySourceHandler.java 86.95% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16097      +/-   ##
============================================
- Coverage     71.68%   71.56%   -0.13%     
+ Complexity    64768    64606     -162     
============================================
  Files          5278     5278              
  Lines        302647   302669      +22     
  Branches      44028    44035       +7     
============================================
- Hits         216955   216605     -350     
- Misses        67592    67909     +317     
- Partials      18100    18155      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 5695d57 into 2.x Sep 27, 2024
58 of 59 checks passed
@gbbafna gbbafna deleted the backport/backport-15578-to-2.x branch September 27, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants