-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add validation for the search backpressure cancellation settings #15969
[Backport 2.x] Add validation for the search backpressure cancellation settings #15969
Conversation
…nsearch-project#15501) * Fix updating search backpressure settings crashing the cluster Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> * Fix version check Signed-off-by: Gao Binlong <[email protected]> * Increase test coverage Signed-off-by: Gao Binlong <[email protected]> * Format the code Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> * Fix typo Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit 8347d0e)
rest-api-spec/src/main/resources/rest-api-spec/test/cluster.put_settings/10_basic.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: Gao Binlong <[email protected]>
❕ Gradle check result for c97fcc4: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15969 +/- ##
============================================
+ Coverage 71.67% 71.76% +0.08%
- Complexity 64624 64705 +81
============================================
Files 5276 5276
Lines 302298 302332 +34
Branches 43992 43995 +3
============================================
+ Hits 216674 216961 +287
+ Misses 67532 67232 -300
- Partials 18092 18139 +47 ☔ View full report in Codecov by Sentry. |
Hi @reta, do you know how to fix the failure of detect breaking changes check? The report shows a new public method is added(in this PR), and a public method is removed(by another PR). |
Thanks @gaobinlong , fix is raised #15980 |
Description
Backport #15501 to 2.x
Related Issues
#15495
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.