-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmute snapshot status tests from #15652 #15876
Unmute snapshot status tests from #15652 #15876
Conversation
❕ Gradle check result for c52575c: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15876 +/- ##
============================================
- Coverage 71.85% 71.84% -0.01%
+ Complexity 64213 64190 -23
============================================
Files 5272 5272
Lines 300538 300538
Branches 43432 43432
============================================
- Hits 215947 215932 -15
- Misses 66833 66868 +35
+ Partials 17758 17738 -20 ☔ View full report in Codecov by Sentry. |
|
❌ Gradle check result for c52575c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test #14295 |
c52575c
to
ffd4386
Compare
ffd4386
to
b7eb368
Compare
This reverts commit 48cf5f0. Signed-off-by: Lakshya Taragi <[email protected]>
b7eb368
to
e7fdcac
Compare
As the tests were not reproducible locally, we have run 5 gradle builds with the unmuted tests and didn't see any failures associated with them. |
This reverts commit 48cf5f0. Signed-off-by: Lakshya Taragi <[email protected]> (cherry picked from commit c709400) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15876-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c709400543a16d7f7d6d644f26bb2f7a10b90caf
# Push it to GitHub
git push --set-upstream origin backport/backport-15876-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17 Then, create a pull request where the |
This reverts commit 48cf5f0. (cherry picked from commit c709400) Signed-off-by: Lakshya Taragi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project#15876) This reverts commit 48cf5f0. Signed-off-by: Lakshya Taragi <[email protected]>
opensearch-project#15876) This reverts commit 48cf5f0. Signed-off-by: Lakshya Taragi <[email protected]>
opensearch-project#15876) This reverts commit 48cf5f0. Signed-off-by: Lakshya Taragi <[email protected]>
opensearch-project#15876) This reverts commit 48cf5f0. Signed-off-by: Lakshya Taragi <[email protected]>
Description
This reverts commit 48cf5f0 (#15652)
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.