Add more wait time to assertBusy to fix RemoteFsTimestampAwareTranslo… #15865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15865 +/- ##
============================================
+ Coverage 71.94% 72.47% +0.53%
- Complexity 64224 64728 +504
============================================
Files 5272 5272
Lines 300538 300538
Branches 43432 43432
============================================
+ Hits 216212 217806 +1594
+ Misses 66575 65320 -1255
+ Partials 17751 17412 -339 ☔ View full report in Codecov by Sentry. |
…gTests.testSimpleOperationsUpload Signed-off-by: Sachin Kale <[email protected]>
sachinpkale
force-pushed
the
testSimpleOperationsUpload-fix
branch
from
b37ea44 to
e2bbd19
Compare
|
❕ Gradle check result for e2bbd19: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
❕ Gradle check result for e2bbd19: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
sachinpkale
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❕ Gradle check result for e2bbd19: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
gbbafna
approved these changes
Sep 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…gTests.testSimpleOperationsUpload (#15865) Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 92d7fe8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 11, 2024
sachinpkale
pushed a commit
that referenced
this pull request
Sep 12, 2024
…gTests.testSimpleOperationsUpload (#15865) Signed-off-by: Sachin Kale <[email protected]> (cherry picked from commit 92d7fe8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
that referenced
this pull request
Sep 12, 2024
…gTests.testSimpleOperationsUpload (#15865) (#15894) (cherry picked from commit 92d7fe8) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…gTests.testSimpleOperationsUpload (opensearch-project#15865) Signed-off-by: Sachin Kale <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…gTests.testSimpleOperationsUpload (opensearch-project#15865) Signed-off-by: Sachin Kale <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…gTests.testSimpleOperationsUpload (opensearch-project#15865) Signed-off-by: Sachin Kale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RemoteFsTimestampAwareTranslogTests.testSimpleOperationsUploadtest is flaky at assertion which checks for number of metadata files in remote translog aftertrimUnreferencedReadersis called.assertBusytimeout.Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.