-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest test case #15859
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15859 +/- ##
============================================
+ Coverage 71.86% 71.92% +0.06%
- Complexity 64317 64319 +2
============================================
Files 5278 5278
Lines 300833 300833
Branches 43473 43473
============================================
+ Hits 216196 216377 +181
+ Misses 66915 66656 -259
- Partials 17722 17800 +78 ☔ View full report in Codecov by Sentry. |
❕ Gradle check result for 5bb9793: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
...reactor-netty4/src/javaRestTest/java/org/opensearch/rest/ReactorNetty4StreamingStressIT.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for a6e014f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…eClientStreamingRequest test case Signed-off-by: Andriy Redko <[email protected]>
❕ Gradle check result for 6e96f4a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@mch2 do you mind to reapprove please? thank you! |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15859-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 260edc5f13debc04858da4e73dfc396eeb459ef9
# Push it to GitHub
git push --set-upstream origin backport/backport-15859-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15859-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 260edc5f13debc04858da4e73dfc396eeb459ef9
# Push it to GitHub
git push --set-upstream origin backport/backport-15859-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17 Then, create a pull request where the |
…eClientStreamingRequest test case (opensearch-project#15859) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 260edc5) Signed-off-by: Andriy Redko <[email protected]>
…eClientStreamingRequest test case (#15859) (#15932) (cherry picked from commit 260edc5) Signed-off-by: Andriy Redko <[email protected]>
…eClientStreamingRequest test case (#15859) (#15932) (cherry picked from commit 260edc5) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit a968790) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…eClientStreamingRequest test case (#15859) (#15932) (#15935) (cherry picked from commit 260edc5) (cherry picked from commit a968790) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…eClientStreamingRequest test case (opensearch-project#15859) Signed-off-by: Andriy Redko <[email protected]>
…eClientStreamingRequest test case (opensearch-project#15859) Signed-off-by: Andriy Redko <[email protected]>
…eClientStreamingRequest test case (opensearch-project#15859) Signed-off-by: Andriy Redko <[email protected]>
…eClientStreamingRequest test case (opensearch-project#15859) Signed-off-by: Andriy Redko <[email protected]>
Description
Fix flaky org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest test case
Related Issues
Resolves #15840
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.