Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest test case #15859

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Sep 9, 2024

Description

Fix flaky org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest test case

Related Issues

Resolves #15840

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

✅ Gradle check result for c444eac: SUCCESS

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.92%. Comparing base (4223fab) to head (6e96f4a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15859      +/-   ##
============================================
+ Coverage     71.86%   71.92%   +0.06%     
- Complexity    64317    64319       +2     
============================================
  Files          5278     5278              
  Lines        300833   300833              
  Branches      43473    43473              
============================================
+ Hits         216196   216377     +181     
+ Misses        66915    66656     -259     
- Partials      17722    17800      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

❕ Gradle check result for 5bb9793: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta added the backport 2.x Backport to 2.x branch label Sep 9, 2024
Copy link
Contributor

✅ Gradle check result for 3f8f298: SUCCESS

@reta
Copy link
Collaborator Author

reta commented Sep 11, 2024

@mch2 @andrross @dblock folks mind helping me here please? thank you!

Copy link
Contributor

❌ Gradle check result for a6e014f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…eClientStreamingRequest test case

Signed-off-by: Andriy Redko <[email protected]>
Copy link
Contributor

❕ Gradle check result for 6e96f4a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta
Copy link
Collaborator Author

reta commented Sep 13, 2024

@mch2 do you mind to reapprove please? thank you!

@dblock dblock merged commit 260edc5 into opensearch-project:main Sep 13, 2024
34 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15859-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 260edc5f13debc04858da4e73dfc396eeb459ef9
# Push it to GitHub
git push --set-upstream origin backport/backport-15859-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15859-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15859-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 260edc5f13debc04858da4e73dfc396eeb459ef9
# Push it to GitHub
git push --set-upstream origin backport/backport-15859-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15859-to-2.17.

reta added a commit to reta/OpenSearch that referenced this pull request Sep 13, 2024
…eClientStreamingRequest test case (opensearch-project#15859)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 260edc5)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit that referenced this pull request Sep 13, 2024
…eClientStreamingRequest test case (#15859) (#15932)

(cherry picked from commit 260edc5)

Signed-off-by: Andriy Redko <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 13, 2024
…eClientStreamingRequest test case (#15859) (#15932)

(cherry picked from commit 260edc5)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit a968790)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Sep 13, 2024
…eClientStreamingRequest test case (#15859) (#15932) (#15935)

(cherry picked from commit 260edc5)


(cherry picked from commit a968790)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Sep 19, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut backport 2.x Backport to 2.x branch backport 2.17 backport-failed flaky-test Random test failure that succeeds on second run skip-changelog >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for ReactorNetty4StreamingStressIT
3 participants