Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise memory for rest cluster health calls with in-line shard aggr… #15799

Merged

Conversation

SwethaGuptha
Copy link
Contributor

@SwethaGuptha SwethaGuptha commented Sep 6, 2024

…egations for levels cluster and indices. (#15492)

Description

Backport #15492 to 2.17

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for 67b9165: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna
Copy link
Collaborator

gbbafna commented Sep 6, 2024

[org.opensearch.indices.settings.SearchOnlyReplicaIT.testFailoverWithSearchReplica_WithoutWriterReplicas](https://build.ci.opensearch.org/job/gradle-check/47474/testReport/junit/org.opensearch.indices.settings/SearchOnlyReplicaIT/testFailoverWithSearchReplica_WithoutWriterReplicas/)
    [org.opensearch.recovery.RelocationIT.testIndexSearchAndRelocateConcurrently {p0={"cluster.indices.replication.strategy":"SEGMENT"}}](https://build.ci.opensearch.org/job/gradle-check/47474/testReport/junit/org.opensearch.recovery/RelocationIT/testIndexSearchAndRelocateConcurrently__p0___cluster_indices_replication_strategy___SEGMENT___/)

Looks like new flaky tests .

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for 67b9165: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…gations for levels cluster and indices. (opensearch-project#15492)

Signed-off-by: Swetha Guptha <[email protected]>
@SwethaGuptha SwethaGuptha force-pushed the backport-15492-to-2.17 branch from 67b9165 to 7c54d31 Compare September 6, 2024 13:59
Copy link
Contributor

github-actions bot commented Sep 6, 2024

✅ Gradle check result for 7c54d31: SUCCESS

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 93.92265% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.62%. Comparing base (0c3f2b4) to head (7c54d31).
Report is 2 commits behind head on 2.17.

Files with missing lines Patch % Lines
...on/admin/cluster/health/ClusterHealthResponse.java 64.28% 4 Missing and 1 partial ⚠️
.../opensearch/cluster/health/ClusterIndexHealth.java 95.83% 1 Missing and 2 partials ⚠️
...in/cluster/health/ClusterHealthRequestBuilder.java 0.00% 2 Missing ⚠️
.../opensearch/cluster/health/ClusterShardHealth.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15799      +/-   ##
============================================
+ Coverage     71.61%   71.62%   +0.01%     
+ Complexity    64505    64491      -14     
============================================
  Files          5264     5264              
  Lines        301860   302016     +156     
  Branches      43942    43966      +24     
============================================
+ Hits         216178   216321     +143     
+ Misses        67637    67625      -12     
- Partials      18045    18070      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 4b8f9c8 into opensearch-project:2.17 Sep 6, 2024
35 checks passed
@gbbafna
Copy link
Collaborator

gbbafna commented Sep 6, 2024

Need to get 2.x and main PR merged to get gradle runs running . The 2.x gradle run is not going green . Will retry it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants