Renaming "slave" terminology to replica. #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishikesh Pasham <[email protected]>
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success a4dc2f9 |
|
✅ Gradle Precommit success a4dc2f9 |
tlfeng
approved these changes
Nov 17, 2021
|
Isn't this an API change? What are the consequences for the users? |
The file changed here is used by a BWC test to validate that a Metricbeat template can be used to create an index. The exact name of the field in the template is unimportant to the test so this change should have no impact on the test. This is only a test artifact and there is no API change. |
dblock
approved these changes
Nov 22, 2021
dblock
added
the
pending backport
|
Let's backport to 1.x branch too, please. |
5 tasks
dblock
removed
the
pending backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rishikesh Pasham [email protected]
Description
Renaming slave to replica in filebeat-6.0.template.json file
Issues Resolved
#1556
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.