-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare strings with equals() instead of == #15356
Conversation
@dk2k - The change looks fine. Can you add the description template and CHANGELOG description? Also, all commits need to signed off for DCO check |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15356 +/- ##
============================================
- Coverage 71.93% 71.86% -0.07%
+ Complexity 63223 63189 -34
============================================
Files 5214 5214
Lines 295938 295938
Branches 42754 42754
============================================
- Hits 212876 212687 -189
- Misses 65601 65819 +218
+ Partials 17461 17432 -29 ☔ View full report in Codecov by Sentry. |
I think for something like this we can skip-changelog. |
This PR is stalled because it has been open for 30 days with no activity. |
Closing as this is duplicated by #15369 |
No description provided.