Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare strings with equals() instead of == #15356

Closed
wants to merge 1 commit into from

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Aug 22, 2024

No description provided.

jainankitk
jainankitk previously approved these changes Aug 22, 2024
@jainankitk jainankitk self-requested a review August 22, 2024 18:01
@jainankitk
Copy link
Collaborator

jainankitk commented Aug 22, 2024

@dk2k - The change looks fine. Can you add the description template and CHANGELOG description? Also, all commits need to signed off for DCO check

@jainankitk jainankitk dismissed their stale review August 22, 2024 18:03

DCO failing

@dk2k dk2k marked this pull request as draft August 22, 2024 18:17
Copy link
Contributor

✅ Gradle check result for 1a355fd: SUCCESS

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.86%. Comparing base (abb1041) to head (1a355fd).
Report is 312 commits behind head on main.

Files with missing lines Patch % Lines
...earch/suggest/phrase/NoisyChannelSpellChecker.java 0.00% 0 Missing and 2 partials ⚠️
...h/common/lucene/search/MultiPhrasePrefixQuery.java 0.00% 0 Missing and 1 partial ⚠️
...ons/bucket/composite/UnsignedLongValuesSource.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15356      +/-   ##
============================================
- Coverage     71.93%   71.86%   -0.07%     
+ Complexity    63223    63189      -34     
============================================
  Files          5214     5214              
  Lines        295938   295938              
  Branches      42754    42754              
============================================
- Hits         212876   212687     -189     
- Misses        65601    65819     +218     
+ Partials      17461    17432      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Aug 23, 2024

I think for something like this we can skip-changelog.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Sep 23, 2024
@dbwiddis
Copy link
Member

Closing as this is duplicated by #15369

@dbwiddis dbwiddis closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants