-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add query group stats constructs #15343
add query group stats constructs #15343
Conversation
❌ Gradle check result for 9f34c30: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 52330cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 31f5405: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
31f5405
to
7fada74
Compare
❌ Gradle check result for ce813f1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/wlm/stats/QueryGroupState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/wlm/stats/QueryGroupState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/wlm/stats/QueryGroupState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/wlm/stats/QueryGroupStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/wlm/stats/QueryGroupStats.java
Outdated
Show resolved
Hide resolved
Also, gradle precommit is failing for this PR |
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
❌ Gradle check result for 353b1c8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15343 +/- ##
============================================
- Coverage 71.95% 71.87% -0.09%
- Complexity 63286 63302 +16
============================================
Files 5225 5227 +2
Lines 296215 296323 +108
Branches 42788 42800 +12
============================================
- Hits 213133 212971 -162
- Misses 65559 65892 +333
+ Partials 17523 17460 -63 ☔ View full report in Codecov by Sentry. |
* add query group stats constructs Signed-off-by: Kaushal Kumar <[email protected]> * add changelog entry Signed-off-by: Kaushal Kumar <[email protected]> * add packageinfo for stats Signed-off-by: Kaushal Kumar <[email protected]> * add total cancellations Signed-off-by: Kaushal Kumar <[email protected]> * add more granular level rejections Signed-off-by: Kaushal Kumar <[email protected]> * add toXContent test cases Signed-off-by: Kaushal Kumar <[email protected]> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <[email protected]> * update the comment for query group stats Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> (cherry picked from commit c0bcacb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* add query group stats constructs * add changelog entry * add packageinfo for stats * add total cancellations * add more granular level rejections * add toXContent test cases * move ResourceType enum to wlm * update the comment for query group stats --------- (cherry picked from commit c0bcacb) Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This reverts commit c63ad5a. Signed-off-by: Andriy Redko <[email protected]>
* add query group stats constructs Signed-off-by: Kaushal Kumar <[email protected]> * add changelog entry Signed-off-by: Kaushal Kumar <[email protected]> * add packageinfo for stats Signed-off-by: Kaushal Kumar <[email protected]> * add total cancellations Signed-off-by: Kaushal Kumar <[email protected]> * add more granular level rejections Signed-off-by: Kaushal Kumar <[email protected]> * add toXContent test cases Signed-off-by: Kaushal Kumar <[email protected]> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <[email protected]> * update the comment for query group stats Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
* add query group stats constructs Signed-off-by: Kaushal Kumar <[email protected]> * add changelog entry Signed-off-by: Kaushal Kumar <[email protected]> * add packageinfo for stats Signed-off-by: Kaushal Kumar <[email protected]> * add total cancellations Signed-off-by: Kaushal Kumar <[email protected]> * add more granular level rejections Signed-off-by: Kaushal Kumar <[email protected]> * add toXContent test cases Signed-off-by: Kaushal Kumar <[email protected]> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <[email protected]> * update the comment for query group stats Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
* add query group stats constructs Signed-off-by: Kaushal Kumar <[email protected]> * add changelog entry Signed-off-by: Kaushal Kumar <[email protected]> * add packageinfo for stats Signed-off-by: Kaushal Kumar <[email protected]> * add total cancellations Signed-off-by: Kaushal Kumar <[email protected]> * add more granular level rejections Signed-off-by: Kaushal Kumar <[email protected]> * add toXContent test cases Signed-off-by: Kaushal Kumar <[email protected]> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <[email protected]> * update the comment for query group stats Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
* add query group stats constructs Signed-off-by: Kaushal Kumar <[email protected]> * add changelog entry Signed-off-by: Kaushal Kumar <[email protected]> * add packageinfo for stats Signed-off-by: Kaushal Kumar <[email protected]> * add total cancellations Signed-off-by: Kaushal Kumar <[email protected]> * add more granular level rejections Signed-off-by: Kaushal Kumar <[email protected]> * add toXContent test cases Signed-off-by: Kaushal Kumar <[email protected]> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <[email protected]> * update the comment for query group stats Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
Description
This change introduces constructs to hold live view of query group level stats and point in time view of query group stats. Post these changes we will need changes to hook these constructs with various request events i,e; completions, failures, cancellations and rejections.
Related Issues
Resolves ##15120
RFC: #12342
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.