Fix remote shards balance

[bugmakerrrrrr]

Description

see #15302

Related Issues

Resolves #15302

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

✅ Gradle check result for 229ab75: SUCCESS

[github-actions]

❕ Gradle check result for bd3a94b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.22%. Comparing base (5ba909a) to head (35bec35).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...ing/allocation/allocator/RemoteShardsBalancer.java	55.55%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15335      +/-   ##
============================================
- Coverage     72.11%   71.22%   -0.89%     
+ Complexity    65237    64374     -863     
============================================
  Files          5318     5318              
  Lines        304003   304020      +17     
  Branches      43992    43996       +4     
============================================
- Hits         219228   216546    -2682     
- Misses        66874    69516    +2642     
- Partials      17901    17958      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sohami]

@bugmakerrrrrr Can you please fix the change log conflict

[bugmakerrrrrr]

@bugmakerrrrrr Can you please fix the change log conflict

@sohami done

[github-actions]

❌ Gradle check result for 40bcd07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[bugmakerrrrrr]

hi @andrross , can we merge this? or is there anything else that I need to do for this PR?

[github-actions]

❕ Gradle check result for 35bec35: UNSTABLE

• TEST FAILURES:

      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15335-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b359dd8b9972435b793fd39c6780a02d6ac25ec6
# Push it to GitHub
git push --set-upstream origin backport/backport-15335-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15335-to-2.x.