Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Star tree codec changes #15321

Closed

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Aug 20, 2024

Description

Backport of #14514

There are no conflicts, direct cherry pick of main branch commit.

Related Issues

Resolves #14387

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for 55e18dc: SUCCESS

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 87.91209% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.47%. Comparing base (fcd88aa) to head (bc5bd23).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...ec/composite/datacube/startree/StarTreeValues.java 0.00% 4 Missing ⚠️
...ex/codec/composite/Composite99DocValuesWriter.java 92.10% 0 Missing and 3 partials ⚠️
...ex/codec/composite/Composite99DocValuesFormat.java 80.00% 2 Missing ⚠️
...ex/codec/composite/Composite99DocValuesReader.java 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15321      +/-   ##
============================================
- Coverage     71.54%   71.47%   -0.07%     
+ Complexity    63124    63065      -59     
============================================
  Files          5178     5184       +6     
  Lines        296088   296174      +86     
  Branches      43114    43121       +7     
============================================
- Hits         211828   211697     -131     
- Misses        66541    66702     +161     
- Partials      17719    17775      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❕ Gradle check result for bc5bd23: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@bharath-techie
Copy link
Contributor Author

Closing the PR as auto backport PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant