Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star Tree] [Search] Support for metric aggregations with/without term query #15289

Merged
merged 35 commits into from
Oct 21, 2024

delete tests added accidentally

9742432
Select commit
Loading
Failed to load commit list.
Merged

[Star Tree] [Search] Support for metric aggregations with/without term query #15289

delete tests added accidentally
9742432
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 21, 2024 in 0s

72.14% (target 70.00%)

View this Pull Request on Codecov

72.14% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 83.61204% with 49 lines in your changes missing coverage. Please review.

Project coverage is 72.14%. Comparing base (ad7f9e7) to head (9742432).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...x/datacube/startree/utils/StarTreeQueryHelper.java 71.60% 8 Missing and 15 partials ⚠️
...rch/search/aggregations/metrics/AvgAggregator.java 78.78% 2 Missing and 5 partials ⚠️
...org/opensearch/search/startree/StarTreeFilter.java 93.13% 1 Missing and 6 partials ⚠️
...ensearch/search/startree/StarTreeQueryContext.java 75.00% 2 Missing and 2 partials ⚠️
...main/java/org/opensearch/search/SearchService.java 75.00% 1 Missing and 2 partials ⚠️
...h/index/compositeindex/datacube/DateDimension.java 0.00% 1 Missing ⚠️
...h/index/compositeindex/datacube/ReadDimension.java 0.00% 1 Missing ⚠️
...rch/aggregations/metrics/AvgAggregatorFactory.java 0.00% 1 Missing ⚠️
...rch/aggregations/metrics/MinAggregatorFactory.java 0.00% 1 Missing ⚠️
...regations/metrics/ValueCountAggregatorFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15289      +/-   ##
============================================
+ Coverage     72.05%   72.14%   +0.08%     
- Complexity    64861    64990     +129     
============================================
  Files          5309     5313       +4     
  Lines        302734   303030     +296     
  Branches      43733    43789      +56     
============================================
+ Hits         218134   218607     +473     
+ Misses        66731    66480     -251     
- Partials      17869    17943      +74

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov