Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsibility check for existing shards allocator when timed out #15223

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Aug 13, 2024

Description

With #14848, we introduced capability to make reroute iteration time-bound. Currently OpenSearch uses two primary allocators - ExistingShardsAllocator which is responsible for allocating existing shards, and BalancedShardsAllocator which handles the allocation of all unassigned shards.

This PR adds responsibility check in ExistingShardsAllocator such that newly created shards are not added to ignored list.

Related Issues

Resolves #15222

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Other labels Aug 13, 2024
Copy link
Contributor

❌ Gradle check result for f75154d: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

✅ Gradle check result for fa0ad4e: SUCCESS

Copy link
Contributor

❌ Gradle check result for 474060e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

✅ Gradle check result for 4e8ee65: SUCCESS

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.94%. Comparing base (b6c80b1) to head (4e8ee65).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15223      +/-   ##
============================================
+ Coverage     71.90%   71.94%   +0.03%     
- Complexity    63033    63086      +53     
============================================
  Files          5197     5197              
  Lines        295313   295315       +2     
  Branches      42677    42678       +1     
============================================
+ Hits         212354   212457     +103     
+ Misses        65552    65462      -90     
+ Partials      17407    17396      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit 625dd5a into opensearch-project:main Aug 13, 2024
35 checks passed
@Bukhtawar Bukhtawar added the backport 2.x Backport to 2.x branch label Aug 13, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15223-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 625dd5a3bcd1a56d07f49492225413eae5db58fb
# Push it to GitHub
git push --set-upstream origin backport/backport-15223-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15223-to-2.x.

wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…opensearch-project#15223)

* Fix responsibility check for existing shards allocator when timed out

Signed-off-by: Rishab Nahata <[email protected]>
imRishN added a commit to imRishN/OpenSearch that referenced this pull request Sep 4, 2024
…opensearch-project#15223)

* Fix responsibility check for existing shards allocator when timed out

Signed-off-by: Rishab Nahata <[email protected]>
imRishN added a commit to imRishN/OpenSearch that referenced this pull request Sep 4, 2024
…opensearch-project#15223)

* Fix responsibility check for existing shards allocator when timed out

Signed-off-by: Rishab Nahata <[email protected]>
Bukhtawar pushed a commit that referenced this pull request Sep 4, 2024
…timeout & fix responsibility check for existing shards allocator when timed out (#15650)

* Optimise unassigned shards iteration after allocator timeout (#14977)

* Fix responsibility check for existing shards allocator when timed out (#15223)

Signed-off-by: Rishab Nahata <[email protected]>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
…opensearch-project#15223)

* Fix responsibility check for existing shards allocator when timed out

Signed-off-by: Rishab Nahata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working Other skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] New shards allocation failure for shards present in timed out batches in batch allocator
2 participants