[Backport 2.x] QueryGroup Resource Tracking framework and implementation (#13897) #15154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-project#13897) * initial code for the sandbox resource tracking and cancellation framework Signed-off-by: Kiran Prakash <[email protected]> * Fix Failing Tests Signed-off-by: Kiran Prakash <[email protected]> * spotless Apply Signed-off-by: Kiran Prakash <[email protected]> * Update SandboxService.java Signed-off-by: Kiran Prakash <[email protected]> * Update SandboxService.java Signed-off-by: Kiran Prakash <[email protected]> * Update SandboxTask.java Signed-off-by: Kiran Prakash <[email protected]> * Add java docs Signed-off-by: Kiran Prakash <[email protected]> * spotless Signed-off-by: Kiran Prakash <[email protected]> * javadocs Signed-off-by: Kiran Prakash <[email protected]> * javadocs Signed-off-by: Kiran Prakash <[email protected]> * java docs Signed-off-by: Kiran Prakash <[email protected]> * Update AbstractTaskCancellation.java Signed-off-by: Kiran Prakash <[email protected]> * Update SandboxModule.java Signed-off-by: Kiran Prakash <[email protected]> * Some tests and stubs Signed-off-by: Kiran Prakash <[email protected]> * spotless Signed-off-by: Kiran Prakash <[email protected]> * :server:testingConventions Signed-off-by: Kiran Prakash <[email protected]> * Update AbstractTaskCancellation.java Signed-off-by: Kiran Prakash <[email protected]> * more tests Signed-off-by: Kiran Prakash <[email protected]> * addressing comments Signed-off-by: Kiran Prakash <[email protected]> * revert some accidentally pushed files Signed-off-by: Kiran Prakash <[email protected]> * resolve flakiness Signed-off-by: Kiran Prakash <[email protected]> * renaming sandbox to querygroup and adjusting code based on merged PRs Signed-off-by: Kiran Prakash <[email protected]> * jvm to memory Signed-off-by: Kiran Prakash <[email protected]> * missing java docs Signed-off-by: Kiran Prakash <[email protected]> * spotless Signed-off-by: Kiran Prakash <[email protected]> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <[email protected]> * pluck cancellation changes out of this PR Signed-off-by: Kiran Prakash <[email protected]> * remove unused Signed-off-by: Kiran Prakash <[email protected]> * remove cancellation related code and add more tests coverage Signed-off-by: Kiran Prakash <[email protected]> * us only memory and not jvm Signed-off-by: Kiran Prakash <[email protected]> * test conventions Signed-off-by: Kiran Prakash <[email protected]> * Bring back enum Signed-off-by: Kiran Prakash <[email protected]> * Update SearchBackpressureService.java Signed-off-by: Kiran Prakash <[email protected]> * revert changes Signed-off-by: Kiran Prakash <[email protected]> * revert changes Signed-off-by: Kiran Prakash <[email protected]> * all required changes Signed-off-by: Kiran Prakash <[email protected]> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <[email protected]> * cleanups Signed-off-by: Kiran Prakash <[email protected]> * Delete QueryGroupService.java Signed-off-by: Kiran Prakash <[email protected]> * cleanups Signed-off-by: Kiran Prakash <[email protected]> * Update QueryGroupLevelResourceUsageViewTests.java Signed-off-by: Kiran Prakash <[email protected]> * Update QueryGroupLevelResourceUsageViewTests.java Signed-off-by: Kiran Prakash <[email protected]> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <[email protected]> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <[email protected]> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <[email protected]> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <[email protected]> * rebasing with latest main Signed-off-by: Kiran Prakash <[email protected]> * remove experimental Signed-off-by: Kiran Prakash <[email protected]> * remove queryGroupId Signed-off-by: Kiran Prakash <[email protected]> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <[email protected]> * change code comments Signed-off-by: Kiran Prakash <[email protected]> * remmove QueryGroupUsageTracker Signed-off-by: Kiran Prakash <[email protected]> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <[email protected]> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <[email protected]> * remove QueryGroupTestHelpers Signed-off-by: Kiran Prakash <[email protected]> * cleanups Signed-off-by: Kiran Prakash <[email protected]> * remove queryGroupHelper Signed-off-by: Kiran Prakash <[email protected]> * Update ResourceTypeTests.java Signed-off-by: Kiran Prakash <[email protected]> * extend OpenSearchTestCase Signed-off-by: Kiran Prakash <[email protected]> * pr comments Signed-off-by: Kiran Prakash <[email protected]> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <[email protected]> * Update QueryGroupResourceUsageTrackerServiceTests.java Signed-off-by: Kiran Prakash <[email protected]> * Update ResourceTypeTests.java Signed-off-by: Kiran Prakash <[email protected]> * Update ResourceTypeTests.java Signed-off-by: Kiran Prakash <[email protected]> * Update ResourceType.java Signed-off-by: Kiran Prakash <[email protected]> * Update ResourceType.java Signed-off-by: Kiran Prakash <[email protected]> --------- Signed-off-by: Kiran Prakash <[email protected]> (cherry picked from commit 97c1bf0)
kiranprakash154
changed the title
|
❕ Gradle check result for 0e81e4e: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15154 +/- ##
============================================
+ Coverage 71.48% 71.61% +0.13%
- Complexity 62677 62780 +103
============================================
Files 5123 5129 +6
Lines 294480 294686 +206
Branches 42912 42941 +29
============================================
+ Hits 210518 211053 +535
+ Misses 66286 65951 -335
- Partials 17676 17682 +6 ☔ View full report in Codecov by Sentry. |
kiranprakash154
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
@jed326 can u merge this ? |
jainankitk
approved these changes
Aug 7, 2024
jed326
approved these changes
Aug 8, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport - #13897