[SnapshotV2] Support centralize snapshot creation #15124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocking mechanism Signed-off-by: Anshu Agarwal <[email protected]>
github-actions
bot
added
enhancement
|
❌ Gradle check result for 9142a25: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anshu Agarwal <[email protected]>
|
❌ Gradle check result for d9bbc65: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
added 2 commits
August 6, 2024 16:53
Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: Anshu Agarwal <[email protected]>
|
❌ Gradle check result for 8e85231: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Bukhtawar
changed the title
Bukhtawar
reviewed
Aug 6, 2024
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
Bukhtawar
reviewed
Aug 6, 2024
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 8a507ad: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anshu Agarwal <[email protected]>
|
❌ Gradle check result for 2d404e8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anshu Agarwal <[email protected]>
|
❌ Gradle check result for 90c860c: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sachinpkale
reviewed
Aug 9, 2024
Signed-off-by: Anshu Agarwal <[email protected]>
|
❌ Gradle check result for 193da65: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anshu Agarwal <[email protected]>
anshu1106
requested review from
anasalkouz,
andrross,
ashking94,
CEHENKLE,
dblock,
dbwiddis and
gbbafna
as code owners
3 tasks
anshu1106
added a commit
to anshu1106/OpenSearch
that referenced
this pull request
Sep 2, 2024
…#15124) * Initial Commit to support centralize snapshot creation and implicit locking mechanism Signed-off-by: Anshu Agarwal <[email protected]> * Fix deserilization error Signed-off-by: Anshu Agarwal <[email protected]> * Fix gradle spotless check Signed-off-by: Anshu Agarwal <[email protected]> * Fix listener Signed-off-by: Anshu Agarwal <[email protected]> * Fix test Signed-off-by: Anshu Agarwal <[email protected]> * Fix snapshot generation Signed-off-by: Anshu Agarwal <[email protected]> * Modify cluster setting name Signed-off-by: Anshu Agarwal <[email protected]> * Add more tests Signed-off-by: Anshu Agarwal <[email protected]> * Uncomment pin timestamp code Signed-off-by: Anshu Agarwal <[email protected]> * Modify log messages Signed-off-by: Anshu Agarwal <[email protected]> * Add spotless check failure fix Signed-off-by: Anshu Agarwal <[email protected]> * Fix completion listener for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Elevate cluster state update priority for repository metadata update task Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * Add priority as IMMEDIATE for cluster state repo update task only for v2 snapshots Signed-off-by: Anshu Agarwal <[email protected]> * Fix build error Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless error Signed-off-by: Anshu Agarwal <[email protected]> * Add repository setting for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add integ test to verify snapshot creation if shallow copy repo setting is disabled Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless vilation error Signed-off-by: Anshu Agarwal <[email protected]> * Address review comment Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add min version check for backward compatibility Signed-off-by: Anshu Agarwal <[email protected]> * address review comments Signed-off-by: Anshu Agarwal <[email protected]> * add integ test for master failover scenario Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * refactor code Signed-off-by: Anshu Agarwal <[email protected]> * add changelog Signed-off-by: Anshu Agarwal <[email protected]> * Add pinned timestamp setting in integ tests Signed-off-by: Anshu Agarwal <[email protected]> --------- Signed-off-by: Anshu Agarwal <[email protected]> Signed-off-by: Anshu Agarwal <[email protected]> Co-authored-by: Anshu Agarwal <[email protected]> (cherry picked from commit 23cba28) Signed-off-by: Anshu Agarwal <[email protected]>
3 tasks
ashking94
pushed a commit
that referenced
this pull request
Sep 3, 2024
* [SnapshotV2] Support centralize snapshot creation (#15124) * Initial Commit to support centralize snapshot creation and implicit locking mechanism Signed-off-by: Anshu Agarwal <[email protected]> * Fix deserilization error Signed-off-by: Anshu Agarwal <[email protected]> * Fix gradle spotless check Signed-off-by: Anshu Agarwal <[email protected]> * Fix listener Signed-off-by: Anshu Agarwal <[email protected]> * Fix test Signed-off-by: Anshu Agarwal <[email protected]> * Fix snapshot generation Signed-off-by: Anshu Agarwal <[email protected]> * Modify cluster setting name Signed-off-by: Anshu Agarwal <[email protected]> * Add more tests Signed-off-by: Anshu Agarwal <[email protected]> * Uncomment pin timestamp code Signed-off-by: Anshu Agarwal <[email protected]> * Modify log messages Signed-off-by: Anshu Agarwal <[email protected]> * Add spotless check failure fix Signed-off-by: Anshu Agarwal <[email protected]> * Fix completion listener for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Elevate cluster state update priority for repository metadata update task Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * Add priority as IMMEDIATE for cluster state repo update task only for v2 snapshots Signed-off-by: Anshu Agarwal <[email protected]> * Fix build error Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless error Signed-off-by: Anshu Agarwal <[email protected]> * Add repository setting for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add integ test to verify snapshot creation if shallow copy repo setting is disabled Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless vilation error Signed-off-by: Anshu Agarwal <[email protected]> * Address review comment Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add min version check for backward compatibility Signed-off-by: Anshu Agarwal <[email protected]> * address review comments Signed-off-by: Anshu Agarwal <[email protected]> * add integ test for master failover scenario Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * refactor code Signed-off-by: Anshu Agarwal <[email protected]> * add changelog Signed-off-by: Anshu Agarwal <[email protected]> * Add pinned timestamp setting in integ tests Signed-off-by: Anshu Agarwal <[email protected]> --------- Signed-off-by: Anshu Agarwal <[email protected]> Signed-off-by: Anshu Agarwal <[email protected]> Co-authored-by: Anshu Agarwal <[email protected]> (cherry picked from commit 23cba28) Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless check failure Signed-off-by: Anshu Agarwal <[email protected]> * fix :server:japicmp failure Signed-off-by: Anshu Agarwal <[email protected]> * backort PR#15602 Signed-off-by: Anshu Agarwal <[email protected]> --------- Signed-off-by: Anshu Agarwal <[email protected]> Signed-off-by: Anshu Agarwal <[email protected]> Co-authored-by: Anshu Agarwal <[email protected]>
3 tasks
This was referenced Sep 6, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…#15124) * Initial Commit to support centralize snapshot creation and implicit locking mechanism Signed-off-by: Anshu Agarwal <[email protected]> * Fix deserilization error Signed-off-by: Anshu Agarwal <[email protected]> * Fix gradle spotless check Signed-off-by: Anshu Agarwal <[email protected]> * Fix listener Signed-off-by: Anshu Agarwal <[email protected]> * Fix test Signed-off-by: Anshu Agarwal <[email protected]> * Fix snapshot generation Signed-off-by: Anshu Agarwal <[email protected]> * Modify cluster setting name Signed-off-by: Anshu Agarwal <[email protected]> * Add more tests Signed-off-by: Anshu Agarwal <[email protected]> * Uncomment pin timestamp code Signed-off-by: Anshu Agarwal <[email protected]> * Modify log messages Signed-off-by: Anshu Agarwal <[email protected]> * Add spotless check failure fix Signed-off-by: Anshu Agarwal <[email protected]> * Fix completion listener for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Elevate cluster state update priority for repository metadata update task Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * Add priority as IMMEDIATE for cluster state repo update task only for v2 snapshots Signed-off-by: Anshu Agarwal <[email protected]> * Fix build error Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless error Signed-off-by: Anshu Agarwal <[email protected]> * Add repository setting for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add integ test to verify snapshot creation if shallow copy repo setting is disabled Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless vilation error Signed-off-by: Anshu Agarwal <[email protected]> * Address review comment Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add min version check for backward compatibility Signed-off-by: Anshu Agarwal <[email protected]> * address review comments Signed-off-by: Anshu Agarwal <[email protected]> * add integ test for master failover scenario Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * refactor code Signed-off-by: Anshu Agarwal <[email protected]> * add changelog Signed-off-by: Anshu Agarwal <[email protected]> * Add pinned timestamp setting in integ tests Signed-off-by: Anshu Agarwal <[email protected]> --------- Signed-off-by: Anshu Agarwal <[email protected]> Signed-off-by: Anshu Agarwal <[email protected]> Co-authored-by: Anshu Agarwal <[email protected]>
This was referenced Sep 11, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…#15124) * Initial Commit to support centralize snapshot creation and implicit locking mechanism Signed-off-by: Anshu Agarwal <[email protected]> * Fix deserilization error Signed-off-by: Anshu Agarwal <[email protected]> * Fix gradle spotless check Signed-off-by: Anshu Agarwal <[email protected]> * Fix listener Signed-off-by: Anshu Agarwal <[email protected]> * Fix test Signed-off-by: Anshu Agarwal <[email protected]> * Fix snapshot generation Signed-off-by: Anshu Agarwal <[email protected]> * Modify cluster setting name Signed-off-by: Anshu Agarwal <[email protected]> * Add more tests Signed-off-by: Anshu Agarwal <[email protected]> * Uncomment pin timestamp code Signed-off-by: Anshu Agarwal <[email protected]> * Modify log messages Signed-off-by: Anshu Agarwal <[email protected]> * Add spotless check failure fix Signed-off-by: Anshu Agarwal <[email protected]> * Fix completion listener for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Elevate cluster state update priority for repository metadata update task Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * Add priority as IMMEDIATE for cluster state repo update task only for v2 snapshots Signed-off-by: Anshu Agarwal <[email protected]> * Fix build error Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless error Signed-off-by: Anshu Agarwal <[email protected]> * Add repository setting for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add integ test to verify snapshot creation if shallow copy repo setting is disabled Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless vilation error Signed-off-by: Anshu Agarwal <[email protected]> * Address review comment Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add min version check for backward compatibility Signed-off-by: Anshu Agarwal <[email protected]> * address review comments Signed-off-by: Anshu Agarwal <[email protected]> * add integ test for master failover scenario Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * refactor code Signed-off-by: Anshu Agarwal <[email protected]> * add changelog Signed-off-by: Anshu Agarwal <[email protected]> * Add pinned timestamp setting in integ tests Signed-off-by: Anshu Agarwal <[email protected]> --------- Signed-off-by: Anshu Agarwal <[email protected]> Signed-off-by: Anshu Agarwal <[email protected]> Co-authored-by: Anshu Agarwal <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…#15124) * Initial Commit to support centralize snapshot creation and implicit locking mechanism Signed-off-by: Anshu Agarwal <[email protected]> * Fix deserilization error Signed-off-by: Anshu Agarwal <[email protected]> * Fix gradle spotless check Signed-off-by: Anshu Agarwal <[email protected]> * Fix listener Signed-off-by: Anshu Agarwal <[email protected]> * Fix test Signed-off-by: Anshu Agarwal <[email protected]> * Fix snapshot generation Signed-off-by: Anshu Agarwal <[email protected]> * Modify cluster setting name Signed-off-by: Anshu Agarwal <[email protected]> * Add more tests Signed-off-by: Anshu Agarwal <[email protected]> * Uncomment pin timestamp code Signed-off-by: Anshu Agarwal <[email protected]> * Modify log messages Signed-off-by: Anshu Agarwal <[email protected]> * Add spotless check failure fix Signed-off-by: Anshu Agarwal <[email protected]> * Fix completion listener for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Elevate cluster state update priority for repository metadata update task Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * Add priority as IMMEDIATE for cluster state repo update task only for v2 snapshots Signed-off-by: Anshu Agarwal <[email protected]> * Fix build error Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless error Signed-off-by: Anshu Agarwal <[email protected]> * Add repository setting for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add integ test to verify snapshot creation if shallow copy repo setting is disabled Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless vilation error Signed-off-by: Anshu Agarwal <[email protected]> * Address review comment Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add min version check for backward compatibility Signed-off-by: Anshu Agarwal <[email protected]> * address review comments Signed-off-by: Anshu Agarwal <[email protected]> * add integ test for master failover scenario Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * refactor code Signed-off-by: Anshu Agarwal <[email protected]> * add changelog Signed-off-by: Anshu Agarwal <[email protected]> * Add pinned timestamp setting in integ tests Signed-off-by: Anshu Agarwal <[email protected]> --------- Signed-off-by: Anshu Agarwal <[email protected]> Signed-off-by: Anshu Agarwal <[email protected]> Co-authored-by: Anshu Agarwal <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…#15124) * Initial Commit to support centralize snapshot creation and implicit locking mechanism Signed-off-by: Anshu Agarwal <[email protected]> * Fix deserilization error Signed-off-by: Anshu Agarwal <[email protected]> * Fix gradle spotless check Signed-off-by: Anshu Agarwal <[email protected]> * Fix listener Signed-off-by: Anshu Agarwal <[email protected]> * Fix test Signed-off-by: Anshu Agarwal <[email protected]> * Fix snapshot generation Signed-off-by: Anshu Agarwal <[email protected]> * Modify cluster setting name Signed-off-by: Anshu Agarwal <[email protected]> * Add more tests Signed-off-by: Anshu Agarwal <[email protected]> * Uncomment pin timestamp code Signed-off-by: Anshu Agarwal <[email protected]> * Modify log messages Signed-off-by: Anshu Agarwal <[email protected]> * Add spotless check failure fix Signed-off-by: Anshu Agarwal <[email protected]> * Fix completion listener for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Elevate cluster state update priority for repository metadata update task Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * Add priority as IMMEDIATE for cluster state repo update task only for v2 snapshots Signed-off-by: Anshu Agarwal <[email protected]> * Fix build error Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless error Signed-off-by: Anshu Agarwal <[email protected]> * Add repository setting for snapshot v2 Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add integ test to verify snapshot creation if shallow copy repo setting is disabled Signed-off-by: Anshu Agarwal <[email protected]> * Fix spotless vilation error Signed-off-by: Anshu Agarwal <[email protected]> * Address review comment Signed-off-by: Anshu Agarwal <[email protected]> * Address review comments Signed-off-by: Anshu Agarwal <[email protected]> * Add min version check for backward compatibility Signed-off-by: Anshu Agarwal <[email protected]> * address review comments Signed-off-by: Anshu Agarwal <[email protected]> * add integ test for master failover scenario Signed-off-by: Anshu Agarwal <[email protected]> * Add more integ tests Signed-off-by: Anshu Agarwal <[email protected]> * refactor code Signed-off-by: Anshu Agarwal <[email protected]> * add changelog Signed-off-by: Anshu Agarwal <[email protected]> * Add pinned timestamp setting in integ tests Signed-off-by: Anshu Agarwal <[email protected]> --------- Signed-off-by: Anshu Agarwal <[email protected]> Signed-off-by: Anshu Agarwal <[email protected]> Co-authored-by: Anshu Agarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR centralizes snapshot create operations and integrate with timestamp pinning for snapshot creation. The snapshot creation has a sync execution and it can be scaled independently of number of shards in the cluster.
More details can be found in the RFC
Related Issues
Resolves #15123
Check List
Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.