Fix NODE_SEARCH_CACHE_SIZE_SETTING initialization for TIERED_REMOTE_INDEX_SETTING feature

[neetikasinghal]

Description

This pr fixes NODE_SEARCH_CACHE_SIZE_SETTING initialization for TIERED_REMOTE_INDEX_SETTING feature.
As per current logic, if TIERED_REMOTE_INDEX_SETTING feature flag is enabled, the cache size will always be initialized to 80% irrespective of its search role.

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[neetikasinghal]

@andrross @dblock please review!

[github-actions]

❌ Gradle check result for f5cf1c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 379f283: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

So this was just a mistake, cache is used by search nodes and therefore should be initialized at 80%?

[github-actions]

❌ Gradle check result for 379f283: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[neetikasinghal]

So this was just a mistake, cache is used by search nodes and therefore should be initialized at 80%?

for dedicated search nodes, yes thats the default.

[jed326]

@neetikasinghal can you please rebase? d4e7766 should fix the build failures.

[github-actions]

❌ Gradle check result for ac06640: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[jed326]

@neetikasinghal I think this failure might be related to your change

SettingsException[Unable to initialize the search-data node: Missing value for configuration node.search.cache.size]
	at __randomizedtesting.SeedInfo.seed([72A1176649C8BC87:96BAE4D48127ADAC]:0)
	at app//org.opensearch.node.Node.initializeFileCache(Node.java:2053)
	at app//org.opensearch.node.Node.<init>(Node.java:746)
	at app//org.opensearch.node.MockNode.<init>(MockNode.java:120)
	at app//org.opensearch.node.MockNode.<init>(MockNode.java:108)

[neetikasinghal]

@neetikasinghal I think this failure might be related to your change

SettingsException[Unable to initialize the search-data node: Missing value for configuration node.search.cache.size]
	at __randomizedtesting.SeedInfo.seed([72A1176649C8BC87:96BAE4D48127ADAC]:0)
	at app//org.opensearch.node.Node.initializeFileCache(Node.java:2053)
	at app//org.opensearch.node.Node.<init>(Node.java:746)
	at app//org.opensearch.node.MockNode.<init>(MockNode.java:120)
	at app//org.opensearch.node.MockNode.<init>(MockNode.java:108)

looks like this test needs an update, let me update it.

[github-actions]

✅ Gradle check result for e235bbf: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.80%. Comparing base (48634bd) to head (f3f4201).
Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15076      +/-   ##
============================================
- Coverage     71.82%   71.80%   -0.03%     
- Complexity    62778    62801      +23     
============================================
  Files          5169     5169              
  Lines        294646   294664      +18     
  Branches      42610    42615       +5     
============================================
- Hits         211644   211576      -68     
- Misses        65573    65692     +119     
+ Partials      17429    17396      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ Gradle check result for f3f4201: SUCCESS