Add lower limit for primary and replica batch allocators timeout #14979
Conversation
Signed-off-by: Rishab Nahata <[email protected]>
imRishN
added
skip-changelog
and removed
bug
imRishN
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
Also add the changelog for it. |
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for a0e1606: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ed09df1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for e34e76d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for 26b1d87: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14979 +/- ##
============================================
+ Coverage 71.78% 71.90% +0.11%
- Complexity 62694 62743 +49
============================================
Files 5160 5161 +1
Lines 294211 294372 +161
Branches 42553 42579 +26
============================================
+ Hits 211212 211671 +459
+ Misses 65599 65232 -367
- Partials 17400 17469 +69 ☔ View full report in Codecov by Sentry. |
) * Add lower limit for primary and replica batch allocators Signed-off-by: Rishab Nahata <[email protected]> (cherry picked from commit 09276b3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) (#15026) * Add lower limit for primary and replica batch allocators (cherry picked from commit 09276b3) Signed-off-by: Rishab Nahata <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nsearch-project#14979) * Add lower limit for primary and replica batch allocators Signed-off-by: Rishab Nahata <[email protected]>
…nsearch-project#14979) * Add lower limit for primary and replica batch allocators Signed-off-by: Rishab Nahata <[email protected]>
Description
With this #14848 we added cluster settings for allocator's timeout of which default value is MINUS_ONE. This PR adds a min limit to this setting such that very small values are not added to these settings.
Related Issues
Resolves #14941
Check List
[] API changes companion pull request created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.