Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.16] [BUG FIX] Fix the visit of inner query for NestedQueryBuilder #14968

Conversation

zhichao-aws
Copy link
Member

@zhichao-aws zhichao-aws commented Jul 25, 2024

Description

backport #14739 , solve the conflict in CHANGELOG.md

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zhichao-aws <[email protected]>
Copy link
Contributor

✅ Gradle check result for a608957: SUCCESS

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.56%. Comparing base (61cd3fd) to head (a608957).
Report is 2 commits behind head on 2.16.

Files Patch % Lines
...org/opensearch/index/query/NestedQueryBuilder.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.16   #14968      +/-   ##
============================================
- Coverage     71.56%   71.56%   -0.01%     
- Complexity    62743    62796      +53     
============================================
  Files          5122     5122              
  Lines        294457   294461       +4     
  Branches      42909    42910       +1     
============================================
- Hits         210739   210733       -6     
- Misses        66031    66061      +30     
+ Partials      17687    17667      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaobinlong gaobinlong merged commit b21c13e into opensearch-project:2.16 Jul 25, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants