Cache index shard limit to optimise ShardLimitsAllocationDecider #14962
Conversation
Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for d1e702f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: Rishab Nahata <[email protected]>
imRishN
requested review from
anasalkouz,
andrross,
ashking94,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for ec6ce0b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for fe6e5d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 4ed2164: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for 439bce2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for 818a902: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for 2f3b3e1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
❕ Gradle check result for a93f11d: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
❌ Gradle check result for 950a5aa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14962 +/- ##
============================================
+ Coverage 71.78% 71.86% +0.07%
- Complexity 62694 62752 +58
============================================
Files 5160 5161 +1
Lines 294211 294363 +152
Branches 42553 42577 +24
============================================
+ Hits 211212 211540 +328
+ Misses 65599 65403 -196
- Partials 17400 17420 +20 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rishab Nahata <[email protected]>
) * Cache index shard limit per node Signed-off-by: Rishab Nahata <[email protected]> (cherry picked from commit 122f3f0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) (#15000) * Cache index shard limit per node (cherry picked from commit 122f3f0) Signed-off-by: Rishab Nahata <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nsearch-project#14962) * Cache index shard limit per node Signed-off-by: Rishab Nahata <[email protected]>
…nsearch-project#14962) * Cache index shard limit per node Signed-off-by: Rishab Nahata <[email protected]>
Description
As described in the issue, with large number of shards, ShardsLimitAllocationDecider spends lots of time parsing settings. As a part of this PR, we are caching the setting value to optimise the decider run time.
Benchmark Before Changes
Benchmark After Changes
Percentage improvement while assigning 200k shards - 10.05%
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#14965
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.