Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.16] Create listener to refresh search thread resource usage (#14832) #14923

Merged

Conversation

deshsidd
Copy link
Contributor

@deshsidd deshsidd commented Jul 23, 2024

Backporting #14832 to 2.16

Signed-off-by: Siddhant Deshmukh [email protected]

  • [bug fix] fix incorrect coordinator node search resource usages

Signed-off-by: Chenyang Ji [email protected]

  • fix bug on serialization when passing task resource usage to coordinator

Signed-off-by: Chenyang Ji [email protected]

  • add more unit tests

Signed-off-by: Chenyang Ji [email protected]

  • remove query insights plugin related code

Signed-off-by: Chenyang Ji [email protected]

  • create per request listener to refresh task resource usage

Signed-off-by: Chenyang Ji [email protected]

  • Make new listener API public

Signed-off-by: Siddhant Deshmukh [email protected]

  • Add changelog

Signed-off-by: Siddhant Deshmukh [email protected]

  • Remove wrong files added

Signed-off-by: Siddhant Deshmukh [email protected]

  • Address review comments

Signed-off-by: Siddhant Deshmukh [email protected]

  • Build fix

Signed-off-by: Siddhant Deshmukh [email protected]

  • Make singleton

Signed-off-by: Siddhant Deshmukh [email protected]

  • Address review comments

Signed-off-by: Siddhant Deshmukh [email protected]

  • Make sure listener runs before plugin listeners

Signed-off-by: Siddhant Deshmukh [email protected]

  • Spotless

Signed-off-by: Siddhant Deshmukh [email protected]

  • Minor fix

Signed-off-by: Siddhant Deshmukh [email protected]


Signed-off-by: Chenyang Ji [email protected]
Signed-off-by: Siddhant Deshmukh [email protected]
Signed-off-by: Jay Deng [email protected]
Co-authored-by: Chenyang Ji [email protected]
Co-authored-by: Jay Deng [email protected]
(cherry picked from commit 8ff3bcc)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@deshsidd deshsidd changed the title Create listener to refresh search thread resource usage (#14832) [Backport 2.16] Create listener to refresh search thread resource usage (#14832) Jul 23, 2024
deshsidd added 2 commits July 23, 2024 11:37
…roject#14832)

Signed-off-by: Siddhant Deshmukh <[email protected]>

* [bug fix] fix incorrect coordinator node search resource usages

Signed-off-by: Chenyang Ji <[email protected]>

* fix bug on serialization when passing task resource usage to coordinator

Signed-off-by: Chenyang Ji <[email protected]>

* add more unit tests

Signed-off-by: Chenyang Ji <[email protected]>

* remove query insights plugin related code

Signed-off-by: Chenyang Ji <[email protected]>

* create per request listener to refresh task resource usage

Signed-off-by: Chenyang Ji <[email protected]>

* Make new listener API public

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Add changelog

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Remove wrong files added

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Address review comments

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Build fix

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Make singleton

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Address review comments

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Make sure listener runs before plugin listeners

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Spotless

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Minor fix

Signed-off-by: Siddhant Deshmukh <[email protected]>

---------

Signed-off-by: Chenyang Ji <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Jay Deng <[email protected]>
Co-authored-by: Chenyang Ji <[email protected]>
Co-authored-by: Jay Deng <[email protected]>
(cherry picked from commit 8ff3bcc)
Signed-off-by: Siddhant Deshmukh <[email protected]>
@deshsidd deshsidd force-pushed the backport/backport-14832-to-2.16-final branch from 698477c to 47628d9 Compare July 23, 2024 18:39
Copy link
Contributor

❌ Gradle check result for 698477c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 4466c0f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

deshsidd added 2 commits July 23, 2024 12:36
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
Copy link
Contributor

❌ Gradle check result for 47628d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for cfd529c: SUCCESS

Copy link
Contributor

❌ Gradle check result for 20b4370: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 20b4370: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326
Copy link
Collaborator

jed326 commented Jul 23, 2024

❌ Gradle check result for 20b4370: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 20b4370:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 20b4370: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@jed326 jed326 merged commit edcbfd4 into opensearch-project:2.16 Jul 23, 2024
30 checks passed
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.65%. Comparing base (1c28e4e) to head (20b4370).
Report is 10 commits behind head on 2.16.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.16   #14923      +/-   ##
============================================
+ Coverage     71.55%   71.65%   +0.10%     
- Complexity    62652    62724      +72     
============================================
  Files          5117     5118       +1     
  Lines        293928   294058     +130     
  Branches      42833    42848      +15     
============================================
+ Hits         210319   210718     +399     
+ Misses        65975    65701     -274     
- Partials      17634    17639       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants