Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Implement write and read flow for shard diff file. #14915

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

shailendra0811
Copy link
Contributor

@shailendra0811 shailendra0811 commented Jul 23, 2024

Backport f85a58f from #14684

@shailendra0811 shailendra0811 changed the title Diff pr [Backport 2.x] Implement write and read flow to upload/download shard diff file. Jul 23, 2024
Copy link
Contributor

❌ Gradle check result for ef4c0e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5bdd3df: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shailendra0811 shailendra0811 changed the title [Backport 2.x] Implement write and read flow to upload/download shard diff file. [Backport 2.x] Implement write and read flow to upload/download shard diff file #14684 Jul 23, 2024
@shailendra0811 shailendra0811 changed the title [Backport 2.x] Implement write and read flow to upload/download shard diff file #14684 [Backport 2.x] Implement write and read flow to upload/download shard diff file Jul 23, 2024
Copy link
Contributor

❌ Gradle check result for a8438c6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…ile (opensearch-project#14684)

* Implement write and read flow to upload/download shard diff file.

Signed-off-by: Shailendra Singh <[email protected]>
@shailendra0811 shailendra0811 changed the title [Backport 2.x] Implement write and read flow to upload/download shard diff file [Backport 2.x] Implement write and read flow for shard diff file. Jul 23, 2024
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the description with the typical message that is added to backport PRs. You can refer other manual backport PRs.

Copy link
Contributor

✅ Gradle check result for eb611c7: SUCCESS

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 74.07407% with 56 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (788a7fe) to head (eb611c7).
Report is 11 commits behind head on 2.x.

Files Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 57.77% 14 Missing and 5 partials ⚠️
...h/cluster/routing/RoutingTableIncrementalDiff.java 82.97% 8 Missing ⚠️
...teway/remote/RemoteClusterStateCleanupManager.java 52.94% 6 Missing and 2 partials ⚠️
...ay/remote/routingtable/RemoteRoutingTableDiff.java 76.66% 4 Missing and 3 partials ⚠️
...earch/gateway/remote/ClusterStateDiffManifest.java 76.19% 2 Missing and 3 partials ⚠️
.../routing/remote/NoopRemoteRoutingTableService.java 57.14% 3 Missing ⚠️
...ster/routing/remote/RemoteRoutingTableService.java 76.92% 2 Missing and 1 partial ⚠️
...nsearch/gateway/remote/RemotePersistenceStats.java 60.00% 2 Missing ⚠️
...ting/remote/InternalRemoteRoutingTableService.java 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14915      +/-   ##
============================================
+ Coverage     71.52%   71.54%   +0.01%     
- Complexity    62546    62637      +91     
============================================
  Files          5110     5120      +10     
  Lines        293684   294251     +567     
  Branches      42800    42876      +76     
============================================
+ Hits         210063   210515     +452     
- Misses        65978    66003      +25     
- Partials      17643    17733      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 39da9bd into opensearch-project:2.x Jul 23, 2024
36 of 37 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
…ile (#14684) (#14915)

* Implement write and read flow to upload/download shard diff file.

Signed-off-by: Shailendra Singh <[email protected]>
(cherry picked from commit 39da9bd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…ile (opensearch-project#14684) (opensearch-project#14915)

* Implement write and read flow to upload/download shard diff file.

Signed-off-by: Shailendra Singh <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants