Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update QueryGroup API Logic #14775

Merged
merged 9 commits into from
Sep 4, 2024

address comments

ed85052
Select commit
Loading
Failed to load commit list.
Merged

Add Update QueryGroup API Logic #14775

address comments
ed85052
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 3, 2024 in 1s

71.97% (target 70.00%)

View this Pull Request on Codecov

71.97% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 82.20339% with 42 lines in your changes missing coverage. Please review.

Project coverage is 71.97%. Comparing base (3fc0139) to head (ed85052).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../org/opensearch/wlm/MutableQueryGroupFragment.java 87.50% 7 Missing and 5 partials ⚠️
...ch/plugin/wlm/rest/RestUpdateQueryGroupAction.java 0.00% 8 Missing ⚠️
...in/wlm/action/TransportUpdateQueryGroupAction.java 0.00% 5 Missing ⚠️
...va/org/opensearch/cluster/metadata/QueryGroup.java 86.48% 2 Missing and 3 partials ⚠️
...rch/plugin/wlm/action/UpdateQueryGroupRequest.java 73.33% 4 Missing ⚠️
...ugin/wlm/service/QueryGroupPersistenceService.java 92.85% 2 Missing and 2 partials ⚠️
...arch/plugin/wlm/action/UpdateQueryGroupAction.java 0.00% 3 Missing ⚠️
...pensearch/plugin/wlm/WorkloadManagementPlugin.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14775      +/-   ##
============================================
- Coverage     71.97%   71.97%   -0.01%     
- Complexity    64067    64079      +12     
============================================
  Files          5259     5265       +6     
  Lines        299431   299588     +157     
  Branches      43270    43280      +10     
============================================
+ Hits         215527   215633     +106     
- Misses        66217    66219       +2     
- Partials      17687    17736      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov