Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Create SystemIndexRegistry with helper method matchesSystemIndex #14692

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bf56227 from #14415.

)

* Create new extension point in SystemIndexPlugin for a single plugin to get registered system indices

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* WIP on system indices from IndexNameExpressionResolver

Signed-off-by: Craig Perkins <[email protected]>

* Add test in IndexNameExpressionResolverTests

Signed-off-by: Craig Perkins <[email protected]>

* Remove changes in SystemIndexPlugin

Signed-off-by: Craig Perkins <[email protected]>

* Add method in IndexNameExpressionResolver to get matching system indices

Signed-off-by: Craig Perkins <[email protected]>

* Show how resolver can be chained to get system indices

Signed-off-by: Craig Perkins <[email protected]>

* Fix forbiddenApis check

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Make SystemIndices internal

Signed-off-by: Craig Perkins <[email protected]>

* Remove unneeded changes

Signed-off-by: Craig Perkins <[email protected]>

* Fix CI failures

Signed-off-by: Craig Perkins <[email protected]>

* Fix precommit errors

Signed-off-by: Craig Perkins <[email protected]>

* Use Regex instead of WildcardMatcher

Signed-off-by: Craig Perkins <[email protected]>

* Address code review feedback

Signed-off-by: Craig Perkins <[email protected]>

* Allow caller to pass index expressions

Signed-off-by: Craig Perkins <[email protected]>

* Create SystemIndexRegistry

Signed-off-by: Craig Perkins <[email protected]>

* Update CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Remove singleton limitation

Signed-off-by: Craig Perkins <[email protected]>

* Add javadoc

Signed-off-by: Craig Perkins <[email protected]>

* Add @experimentalapi annotation

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit bf56227)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jul 9, 2024

✅ Gradle check result for 6f076c9: SUCCESS

@reta reta merged commit a4a6bb8 into 2.x Jul 9, 2024
50 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…nsearch-project#14415) (opensearch-project#14692)

* Create new extension point in SystemIndexPlugin for a single plugin to get registered system indices

* Add to CHANGELOG

* WIP on system indices from IndexNameExpressionResolver

* Add test in IndexNameExpressionResolverTests

* Remove changes in SystemIndexPlugin

* Add method in IndexNameExpressionResolver to get matching system indices

* Show how resolver can be chained to get system indices

* Fix forbiddenApis check

* Update CHANGELOG

* Make SystemIndices internal

* Remove unneeded changes

* Fix CI failures

* Fix precommit errors

* Use Regex instead of WildcardMatcher

* Address code review feedback

* Allow caller to pass index expressions

* Create SystemIndexRegistry

* Update CHANGELOG

* Remove singleton limitation

* Add javadoc

* Add @experimentalapi annotation

---------

(cherry picked from commit bf56227)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
@dbwiddis dbwiddis deleted the backport/backport-14415-to-2.x branch July 24, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant