Fix flaky test testDownloadStatsCorrectnessSinglePrimarySingleReplica #14646
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14646 +/- ##
============================================
- Coverage 71.82% 71.72% -0.10%
+ Complexity 62467 62375 -92
============================================
Files 5149 5149
Lines 293396 293396
Branches 42392 42392
============================================
- Hits 210725 210441 -284
- Misses 65245 65546 +301
+ Partials 17426 17409 -17 ☔ View full report in Codecov by Sentry. |
skumawat2025
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
| && zeroStatePrimaryStats.uploadBytesSucceeded > 0 | ||
| ); | ||
| assertTrue(zeroStatePrimaryStats.totalUploadsFailed == 0 && zeroStatePrimaryStats.uploadBytesFailed == 0); | ||
| }, 60, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Let's reduce the assertBusy wait time. Ideally the default value of this method should suffice, let's remove the extra time value we are adding to this assertBusy invocation
There was a problem hiding this comment.
Got it. Keeping the default value of asserBusy() which is 10 seconds.
skumawat2025
added
Storage:Remote
flaky-test
Signed-off-by: Sandeep Kumawat <[email protected]>
|
@skumawat2025 Are you able to reproduce this locally? If so, after how many iterations? |
No Ashish, this did not repro after 5k+ iteration of single test and suit level test runs. But as we are seeing the assertion failures at this line specifically, It is highly possible that the issues is with zero stats assertion statements. I've included these details in the PR description as well. |
|
This PR is stalled because it has been open for 30 days with no activity. |
Flaky test testDownloadStatsCorrectnessSinglePrimarySingleReplica is not repro after 5k+ iteration on single test and suite level runs. This test is failing with AssertError and not reproducible locally. There is no assertBusy for zeroStats assertions, adding it now. Test logging is already enabled on this.
In one of the failures this test is failing at this line:
OpenSearch/server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreStatsIT.java
Line 391 in a9d2050
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.