Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing pagination for _cat/shards #14641

Merged
merged 17 commits into from
Oct 7, 2024

Updating exception message in ShardPaginationStrategy

10f82d2
Select commit
Loading
Failed to load commit list.
Merged

Implementing pagination for _cat/shards #14641

Updating exception message in ShardPaginationStrategy
10f82d2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 1s

72.01% (target 70.00%)

View this Pull Request on Codecov

72.01% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 79.21569% with 53 lines in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (7a58f5e) to head (10f82d2).

Files with missing lines Patch % Lines
...admin/cluster/shards/TransportCatShardsAction.java 0.00% 20 Missing ⚠️
...g/opensearch/rest/action/cat/RestShardsAction.java 47.05% 9 Missing ⚠️
...a/org/opensearch/action/pagination/PageParams.java 75.00% 1 Missing and 5 partials ⚠️
...rch/action/pagination/IndexPaginationStrategy.java 78.26% 0 Missing and 5 partials ⚠️
...va/org/opensearch/action/pagination/PageToken.java 75.00% 1 Missing and 4 partials ⚠️
...action/admin/cluster/shards/CatShardsResponse.java 81.81% 2 Missing and 2 partials ⚠️
...rch/action/pagination/ShardPaginationStrategy.java 95.55% 1 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14641      +/-   ##
============================================
+ Coverage     71.88%   72.01%   +0.12%     
- Complexity    64546    64714     +168     
============================================
  Files          5296     5298       +2     
  Lines        301754   301952     +198     
  Branches      43588    43627      +39     
============================================
+ Hits         216910   217439     +529     
+ Misses        67040    66723     -317     
+ Partials      17804    17790      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov