Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing pagination for _cat/shards #14641

Merged
merged 17 commits into from
Oct 7, 2024

Changing computation of PageToken in ShardStrategy

ede0700
Select commit
Loading
Failed to load commit list.
Merged

Implementing pagination for _cat/shards #14641

Changing computation of PageToken in ShardStrategy
ede0700
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 0s

71.97% (target 70.00%)

View this Pull Request on Codecov

71.97% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 79.18367% with 51 lines in your changes missing coverage. Please review.

Project coverage is 71.97%. Comparing base (bf6566e) to head (ede0700).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...admin/cluster/shards/TransportCatShardsAction.java 0.00% 20 Missing ⚠️
...g/opensearch/rest/action/cat/RestShardsAction.java 47.05% 9 Missing ⚠️
...rch/action/pagination/IndexPaginationStrategy.java 75.00% 2 Missing and 4 partials ⚠️
...a/org/opensearch/action/pagination/PageParams.java 75.00% 1 Missing and 5 partials ⚠️
...va/org/opensearch/action/pagination/PageToken.java 75.00% 1 Missing and 4 partials ⚠️
...action/admin/cluster/shards/CatShardsResponse.java 81.81% 2 Missing and 2 partials ⚠️
...rch/action/pagination/ShardPaginationStrategy.java 98.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14641      +/-   ##
============================================
+ Coverage     71.86%   71.97%   +0.11%     
- Complexity    64460    64635     +175     
============================================
  Files          5291     5293       +2     
  Lines        301620   301808     +188     
  Branches      43571    43609      +38     
============================================
+ Hits         216750   217220     +470     
+ Misses        67074    66814     -260     
+ Partials      17796    17774      -22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov