[Backport 2.x] Bug/sbp cancellation #14502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change cancellation logic to fix disparity bw trackers and resource duress Signed-off-by: Kaushal Kumar <[email protected]> * add additional tests for searchBackpressureService and refactor code Signed-off-by: Kaushal Kumar <[email protected]> * add enumMap instead of list for tracking taskResourceUsageTrackets Signed-off-by: Kaushal Kumar <[email protected]> * add nodeNotInDuress test for nodeDuressTrackers class Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * add entry in CHANGELOG Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * remove wildcard import Signed-off-by: Kaushal Kumar <[email protected]> * streamline imports Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * add additional test case to test the circuit breaker for SBP logic Signed-off-by: Kaushal Kumar <[email protected]> * add missing javadoc to resourece type enum Signed-off-by: Kaushal Kumar <[email protected]> * add javadoc to a method Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc warnings Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc warnings Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> (cherry picked from commit bcccedb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* change cancellation logic to fix disparity bw trackers and resource duress Signed-off-by: Kaushal Kumar <[email protected]> * add additional tests for searchBackpressureService and refactor code Signed-off-by: Kaushal Kumar <[email protected]> * add enumMap instead of list for tracking taskResourceUsageTrackets Signed-off-by: Kaushal Kumar <[email protected]> * add nodeNotInDuress test for nodeDuressTrackers class Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * add entry in CHANGELOG Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * remove wildcard import Signed-off-by: Kaushal Kumar <[email protected]> * streamline imports Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * add additional test case to test the circuit breaker for SBP logic Signed-off-by: Kaushal Kumar <[email protected]> * add missing javadoc to resourece type enum Signed-off-by: Kaushal Kumar <[email protected]> * add javadoc to a method Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc warnings Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc warnings Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
…13474-to-2.x Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
changed the base branch from
backport/backport-13474-to-2.x
to
2.x
|
❌ Gradle check result for dff83cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #14502 +/- ##
============================================
+ Coverage 71.28% 71.49% +0.21%
- Complexity 60145 62271 +2126
============================================
Files 4957 5096 +139
Lines 282799 292810 +10011
Branches 41409 42683 +1274
============================================
+ Hits 201591 209351 +7760
- Misses 64189 65861 +1672
- Partials 17019 17598 +579 ☔ View full report in Codecov by Sentry. |
|
|
@kaushalmahi12 Can you please comment or link where changes were done in this PR to resolve backport errors |
|
This PR: #10028 introduced the additional metric in stats API. |
sohami
approved these changes
Jun 24, 2024
This was referenced Jun 24, 2024
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
* Bug/sbp cancellation (opensearch-project#13474) * change cancellation logic to fix disparity bw trackers and resource duress Signed-off-by: Kaushal Kumar <[email protected]> * add additional tests for searchBackpressureService and refactor code Signed-off-by: Kaushal Kumar <[email protected]> * add enumMap instead of list for tracking taskResourceUsageTrackets Signed-off-by: Kaushal Kumar <[email protected]> * add nodeNotInDuress test for nodeDuressTrackers class Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * add entry in CHANGELOG Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * remove wildcard import Signed-off-by: Kaushal Kumar <[email protected]> * streamline imports Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * add additional test case to test the circuit breaker for SBP logic Signed-off-by: Kaushal Kumar <[email protected]> * add missing javadoc to resourece type enum Signed-off-by: Kaushal Kumar <[email protected]> * add javadoc to a method Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc warnings Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc warnings Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> (cherry picked from commit bcccedb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Bug/sbp cancellation (opensearch-project#13474) * change cancellation logic to fix disparity bw trackers and resource duress Signed-off-by: Kaushal Kumar <[email protected]> * add additional tests for searchBackpressureService and refactor code Signed-off-by: Kaushal Kumar <[email protected]> * add enumMap instead of list for tracking taskResourceUsageTrackets Signed-off-by: Kaushal Kumar <[email protected]> * add nodeNotInDuress test for nodeDuressTrackers class Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * add entry in CHANGELOG Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * remove wildcard import Signed-off-by: Kaushal Kumar <[email protected]> * streamline imports Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * add additional test case to test the circuit breaker for SBP logic Signed-off-by: Kaushal Kumar <[email protected]> * add missing javadoc to resourece type enum Signed-off-by: Kaushal Kumar <[email protected]> * add javadoc to a method Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc warnings Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc warnings Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> * fix compilation error Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport bcccedb from #13474.