-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize UnsignedLong range queries to convert to MatchNoDocsQuery when lower > upper bounds #14416
Optimize UnsignedLong range queries to convert to MatchNoDocsQuery when lower > upper bounds #14416
Conversation
❌ Gradle check result for 4548b63: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
4548b63
to
add784a
Compare
❌ Gradle check result for add784a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for f23212c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
LGTM, thanks @Skyring100 ! Could you please resolved the conflicts? Thank you! |
I am not sure how to resolve these conflicts. I could not find the ResourceAwareTasksTests class mentioned in the stacktrace on my local machine. I have locally run ./gradlew precommit and ./gradlew spotlessApply, both of which were successful. Is there something about flaky tests affecting this issue? |
Signed-off-by: Andriy Redko <[email protected]>
❌ Gradle check result for a187f9e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for a187f9e: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@gaobinlong LGTM? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14416-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d2c08b320b49920e142ec70fa66621305fd4ccf8
# Push it to GitHub
git push --set-upstream origin backport/backport-14416-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@Skyring100 could you please send the backport to |
I'd like to apologize for how many issues there have been, I was unaware of the knowledge needed beyond my programming skills. Thank you all for having patience and helping with the pull request. |
…en lower > upper bounds (opensearch-project#14416) * Added check for lower > upper at end of function Signed-off-by: Skyring100 <[email protected]> * Fixed mistake of using < operator on BigInteger, now using compareTo Signed-off-by: Skyring100 <[email protected]> * Fixed simple mistake of flipping > operator Signed-off-by: Skyring100 <[email protected]> * Fixed space formatting Signed-off-by: Skyring100 <[email protected]> * Updated CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * Issue number linked in CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * doTestDocValueRangeQueries now accepts MatchNoDocsQuery alongside IndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * dotestdoTestDocValueRangeQueries only checks indexQuery and randomAccessQuery only when query is type IndexIndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * Ran gradlew spotlessApply to fix import formatting issues Signed-off-by: Skyring100 <[email protected]> * Imported Matchers.either method instead of entire Matchers class Signed-off-by: Skyring100 <[email protected]> --------- Signed-off-by: Skyring100 <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
…en lower > upper bounds (opensearch-project#14416) * Added check for lower > upper at end of function Signed-off-by: Skyring100 <[email protected]> * Fixed mistake of using < operator on BigInteger, now using compareTo Signed-off-by: Skyring100 <[email protected]> * Fixed simple mistake of flipping > operator Signed-off-by: Skyring100 <[email protected]> * Fixed space formatting Signed-off-by: Skyring100 <[email protected]> * Updated CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * Issue number linked in CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * doTestDocValueRangeQueries now accepts MatchNoDocsQuery alongside IndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * dotestdoTestDocValueRangeQueries only checks indexQuery and randomAccessQuery only when query is type IndexIndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * Ran gradlew spotlessApply to fix import formatting issues Signed-off-by: Skyring100 <[email protected]> * Imported Matchers.either method instead of entire Matchers class Signed-off-by: Skyring100 <[email protected]> --------- Signed-off-by: Skyring100 <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit d2c08b3)
…en lower > upper bounds (opensearch-project#14416) * Added check for lower > upper at end of function Signed-off-by: Skyring100 <[email protected]> * Fixed mistake of using < operator on BigInteger, now using compareTo Signed-off-by: Skyring100 <[email protected]> * Fixed simple mistake of flipping > operator Signed-off-by: Skyring100 <[email protected]> * Fixed space formatting Signed-off-by: Skyring100 <[email protected]> * Updated CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * Issue number linked in CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * doTestDocValueRangeQueries now accepts MatchNoDocsQuery alongside IndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * dotestdoTestDocValueRangeQueries only checks indexQuery and randomAccessQuery only when query is type IndexIndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * Ran gradlew spotlessApply to fix import formatting issues Signed-off-by: Skyring100 <[email protected]> * Imported Matchers.either method instead of entire Matchers class Signed-off-by: Skyring100 <[email protected]> --------- Signed-off-by: Skyring100 <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit d2c08b3) Signed-off-by: Andriy Redko <[email protected]>
…en lower > upper bounds (#14416) (#14483) * Added check for lower > upper at end of function * Fixed mistake of using < operator on BigInteger, now using compareTo * Fixed simple mistake of flipping > operator * Fixed space formatting * Updated CHANGELOG.md * Issue number linked in CHANGELOG.md * doTestDocValueRangeQueries now accepts MatchNoDocsQuery alongside IndexOrDocValuesQuery * dotestdoTestDocValueRangeQueries only checks indexQuery and randomAccessQuery only when query is type IndexIndexOrDocValuesQuery * Ran gradlew spotlessApply to fix import formatting issues * Imported Matchers.either method instead of entire Matchers class --------- (cherry picked from commit d2c08b3) Signed-off-by: Skyring100 <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
…en lower > upper bounds (opensearch-project#14416) * Added check for lower > upper at end of function Signed-off-by: Skyring100 <[email protected]> * Fixed mistake of using < operator on BigInteger, now using compareTo Signed-off-by: Skyring100 <[email protected]> * Fixed simple mistake of flipping > operator Signed-off-by: Skyring100 <[email protected]> * Fixed space formatting Signed-off-by: Skyring100 <[email protected]> * Updated CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * Issue number linked in CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * doTestDocValueRangeQueries now accepts MatchNoDocsQuery alongside IndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * dotestdoTestDocValueRangeQueries only checks indexQuery and randomAccessQuery only when query is type IndexIndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * Ran gradlew spotlessApply to fix import formatting issues Signed-off-by: Skyring100 <[email protected]> * Imported Matchers.either method instead of entire Matchers class Signed-off-by: Skyring100 <[email protected]> --------- Signed-off-by: Skyring100 <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
…en lower > upper bounds (opensearch-project#14416) (opensearch-project#14483) * Added check for lower > upper at end of function * Fixed mistake of using < operator on BigInteger, now using compareTo * Fixed simple mistake of flipping > operator * Fixed space formatting * Updated CHANGELOG.md * Issue number linked in CHANGELOG.md * doTestDocValueRangeQueries now accepts MatchNoDocsQuery alongside IndexOrDocValuesQuery * dotestdoTestDocValueRangeQueries only checks indexQuery and randomAccessQuery only when query is type IndexIndexOrDocValuesQuery * Ran gradlew spotlessApply to fix import formatting issues * Imported Matchers.either method instead of entire Matchers class --------- (cherry picked from commit d2c08b3) Signed-off-by: Skyring100 <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: kkewwei <[email protected]>
…en lower > upper bounds (opensearch-project#14416) * Added check for lower > upper at end of function Signed-off-by: Skyring100 <[email protected]> * Fixed mistake of using < operator on BigInteger, now using compareTo Signed-off-by: Skyring100 <[email protected]> * Fixed simple mistake of flipping > operator Signed-off-by: Skyring100 <[email protected]> * Fixed space formatting Signed-off-by: Skyring100 <[email protected]> * Updated CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * Issue number linked in CHANGELOG.md Signed-off-by: Skyring100 <[email protected]> * doTestDocValueRangeQueries now accepts MatchNoDocsQuery alongside IndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * dotestdoTestDocValueRangeQueries only checks indexQuery and randomAccessQuery only when query is type IndexIndexOrDocValuesQuery Signed-off-by: Skyring100 <[email protected]> * Ran gradlew spotlessApply to fix import formatting issues Signed-off-by: Skyring100 <[email protected]> * Imported Matchers.either method instead of entire Matchers class Signed-off-by: Skyring100 <[email protected]> --------- Signed-off-by: Skyring100 <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
Description
unsignedLongRangeQuery method now returns MatchNoDocsQuery when lower bound > upper bound
Related Issues
Resolves #14404
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.