Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back DEFAULT_CHUNK_SIZE to be visible to public API #14158

Merged
merged 17 commits into from
Jun 11, 2024
Merged

Adding back DEFAULT_CHUNK_SIZE to be visible to public API #14158

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3013bac
Making Recovery Chunk Size setting dynamic
Jun 5, 2024
35c6832
Adding changelog
Jun 5, 2024
e8dee7e
Rebasing from main
Jun 6, 2024
544bcbd
Merge branch 'main' of https://github.com/opensearch-project/OpenSear…
Jun 6, 2024
91ca0d2
Removing RecoverySettingsChunkSizePlugin
Jun 6, 2024
eb1dd56
addresed comment on PR
Jun 6, 2024
dbcc714
Merge from main
Jun 6, 2024
bce9043
Merge branch 'main' into flush_bug
gbbafna Jun 7, 2024
6099cd4
Merge branch 'main' into flush_bug
gbbafna Jun 7, 2024
b77fe5c
Merge branch 'main' of https://github.com/opensearch-project/OpenSear…
Jun 7, 2024
27b524a
few changes
Jun 7, 2024
d08cbfc
Merge branch 'main' of https://github.com/opensearch-project/OpenSear…
Jun 10, 2024
15c29ce
Merge branch 'main' of https://github.com/opensearch-project/OpenSear…
Jun 10, 2024
9d825f7
Update TruncatedRecoveryIT.java
gbbafna Jun 10, 2024
8e05076
Adding back imports
Jun 10, 2024
f560fa8
Merge branch 'main' of https://github.com/opensearch-project/OpenSear…
Jun 11, 2024
0bbf76a
Adding back DEFAULT_CHUNK_SIZE, to be visible to piblicAPI
Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/src/main/java/org/opensearch/indices/recovery/RecoverySettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,11 @@ public class RecoverySettings {
);

// choose 512KB-16B to ensure that the resulting byte[] is not a humongous allocation in G1.
public static final ByteSizeValue DEFAULT_CHUNK_SIZE = new ByteSizeValue(512 * 1024 - 16, ByteSizeUnit.BYTES);

public static final Setting<ByteSizeValue> INDICES_RECOVERY_CHUNK_SIZE_SETTING = Setting.byteSizeSetting(
"indices.recovery.chunk_size",
new ByteSizeValue(512 * 1024 - 16, ByteSizeUnit.BYTES),
DEFAULT_CHUNK_SIZE,
new ByteSizeValue(1, ByteSizeUnit.BYTES),
new ByteSizeValue(100, ByteSizeUnit.MB),
Property.Dynamic,
Expand Down
Loading