-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support to provide tags with value in Gauge metric #13994
Conversation
@reta, Please take a look. Thanks! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13994 +/- ##
============================================
+ Coverage 71.42% 71.67% +0.25%
- Complexity 59978 61588 +1610
============================================
Files 4985 5082 +97
Lines 282275 289084 +6809
Branches 40946 41836 +890
============================================
+ Hits 201603 207198 +5595
- Misses 63999 64795 +796
- Partials 16673 17091 +418 ☔ View full report in Codecov by Sentry. |
libs/telemetry/src/main/java/org/opensearch/telemetry/metrics/ObservableMeasurement.java
Outdated
Show resolved
Hide resolved
libs/telemetry/src/main/java/org/opensearch/telemetry/metrics/MetricsRegistry.java
Show resolved
Hide resolved
libs/telemetry/src/main/java/org/opensearch/telemetry/metrics/TaggedMeasurement.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 472af7f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3d78aea: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3d78aea: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Juneja <[email protected]>
❌ Gradle check result for 4f3e265: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Juneja <[email protected]>
❌ Gradle check result for c761859: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gagan Juneja <[email protected]>
@reta, Need your help in merging this. Thanks! |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13994-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 24d70696ae4e145fccf6042c1f9b9f83b64677b8
# Push it to GitHub
git push --set-upstream origin backport/backport-13994-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@Gaganjuneja the backport failed sadly, could you please send a manual one? thank you |
backport is failing because of this open PR - #14118 |
Not sure I got it, there is no backport PR afaict |
…roject#13994) * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds build issue Signed-off-by: Gagan Juneja <[email protected]> * Fix compilation issue Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]>
…roject#13994) * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds build issue Signed-off-by: Gagan Juneja <[email protected]> * Fix compilation issue Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]>
) * Adds support to provide tags with value in Gauge metric * Adds support to provide tags with value in Gauge metric * Adds support to provide tags with value in Gauge metric * Adds build issue * Fix compilation issue * Empty-Commit * Empty-Commit --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]>
…roject#13994) (opensearch-project#14138) * Adds support to provide tags with value in Gauge metric * Adds support to provide tags with value in Gauge metric * Adds support to provide tags with value in Gauge metric * Adds build issue * Fix compilation issue * Empty-Commit * Empty-Commit --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> Signed-off-by: kkewwei <[email protected]>
…roject#13994) * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds build issue Signed-off-by: Gagan Juneja <[email protected]> * Fix compilation issue Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]>
Description
Updates the definition of a Gauge meter to add tags at value level instead of the meter.
Related Issues
Resolves #13991
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.