-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten PR template checklist and remove verification workflow #13979
Conversation
@peternied are you OK with this checklist? thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrross Thanks for making these changes, lets see how this works out.
This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR. This also removes the check that enforces checklist completion as requested by issue opensearch-project#10970. Resolves opensearch-project#13965 Resolves opensearch-project#10970 Signed-off-by: Andrew Ross <[email protected]>
f801ce6
to
497052a
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13979-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ac78f0a4dc39f5b4be32adc8bf54999b2b44cd14
# Push it to GitHub
git push --set-upstream origin backport/backport-13979-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR. This also removes the check that enforces checklist completion as requested by issue opensearch-project#10970. Resolves opensearch-project#13965 Resolves opensearch-project#10970 Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit ac78f0a)
This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR. This also removes the check that enforces checklist completion as requested by issue opensearch-project#10970. Resolves opensearch-project#13965 Resolves opensearch-project#10970 Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit ac78f0a)
This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR. This also removes the check that enforces checklist completion as requested by issue #10970. Resolves #13965 Resolves #10970 Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit ac78f0a)
This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR. This also removes the check that enforces checklist completion as requested by issue opensearch-project#10970. Resolves opensearch-project#13965 Resolves opensearch-project#10970 Signed-off-by: Andrew Ross <[email protected]>
This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR. This also removes the check that enforces checklist completion as requested by issue opensearch-project#10970. Resolves opensearch-project#13965 Resolves opensearch-project#10970 Signed-off-by: Andrew Ross <[email protected]>
…project#14009) This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR. This also removes the check that enforces checklist completion as requested by issue opensearch-project#10970. Resolves opensearch-project#13965 Resolves opensearch-project#10970 Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit ac78f0a) Signed-off-by: kkewwei <[email protected]>
This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR. This also removes the check that enforces checklist completion as requested by issue opensearch-project#10970. Resolves opensearch-project#13965 Resolves opensearch-project#10970 Signed-off-by: Andrew Ross <[email protected]>
This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR.
Related Issues
Resolves #13965
Resolves #10970
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.