Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten PR template checklist and remove verification workflow #13979

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

andrross
Copy link
Member

@andrross andrross commented Jun 4, 2024

This commit removes items from the checklist that were redundant in order to reduce the work required to submit a PR.

Related Issues

Resolves #13965
Resolves #10970

Check List

  • Functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross requested a review from peternied as a code owner June 4, 2024 23:11
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Other labels Jun 4, 2024
@reta
Copy link
Collaborator

reta commented Jun 5, 2024

@peternied are you OK with this checklist? thank you

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrross Thanks for making these changes, lets see how this works out.

.github/workflows/pull-request-checks.yml Outdated Show resolved Hide resolved
This commit removes items from the checklist that were redundant in
order to reduce the work required to submit a PR. This also removes the
check that enforces checklist completion as requested by issue opensearch-project#10970.

Resolves opensearch-project#13965
Resolves opensearch-project#10970

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross force-pushed the pr-checklist-update branch from f801ce6 to 497052a Compare June 5, 2024 15:54
@andrross andrross changed the title Shorten PR template checklist Shorten PR template checklist and remove verification workflow Jun 5, 2024
@github-actions github-actions bot added Meta Meta issue, not directly linked to a PR stalled Issues that have stalled labels Jun 5, 2024
@andrross andrross added the backport 2.x Backport to 2.x branch label Jun 5, 2024
@andrross andrross merged commit ac78f0a into opensearch-project:main Jun 5, 2024
32 checks passed
@andrross andrross deleted the pr-checklist-update branch June 5, 2024 17:04
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13979-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ac78f0a4dc39f5b4be32adc8bf54999b2b44cd14
# Push it to GitHub
git push --set-upstream origin backport/backport-13979-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13979-to-2.x.

andrross added a commit to andrross/OpenSearch that referenced this pull request Jun 5, 2024
This commit removes items from the checklist that were redundant in
order to reduce the work required to submit a PR. This also removes the
check that enforces checklist completion as requested by issue opensearch-project#10970.

Resolves opensearch-project#13965
Resolves opensearch-project#10970

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit ac78f0a)
andrross added a commit to andrross/OpenSearch that referenced this pull request Jun 5, 2024
This commit removes items from the checklist that were redundant in
order to reduce the work required to submit a PR. This also removes the
check that enforces checklist completion as requested by issue opensearch-project#10970.

Resolves opensearch-project#13965
Resolves opensearch-project#10970

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit ac78f0a)
reta pushed a commit that referenced this pull request Jun 5, 2024
This commit removes items from the checklist that were redundant in
order to reduce the work required to submit a PR. This also removes the
check that enforces checklist completion as requested by issue #10970.

Resolves #13965
Resolves #10970

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit ac78f0a)
LantaoJin pushed a commit to LantaoJin/OpenSearch that referenced this pull request Jun 6, 2024
This commit removes items from the checklist that were redundant in
order to reduce the work required to submit a PR. This also removes the
check that enforces checklist completion as requested by issue opensearch-project#10970.

Resolves opensearch-project#13965
Resolves opensearch-project#10970

Signed-off-by: Andrew Ross <[email protected]>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
This commit removes items from the checklist that were redundant in
order to reduce the work required to submit a PR. This also removes the
check that enforces checklist completion as requested by issue opensearch-project#10970.

Resolves opensearch-project#13965
Resolves opensearch-project#10970

Signed-off-by: Andrew Ross <[email protected]>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…project#14009)

This commit removes items from the checklist that were redundant in
order to reduce the work required to submit a PR. This also removes the
check that enforces checklist completion as requested by issue opensearch-project#10970.

Resolves opensearch-project#13965
Resolves opensearch-project#10970

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit ac78f0a)
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
This commit removes items from the checklist that were redundant in
order to reduce the work required to submit a PR. This also removes the
check that enforces checklist completion as requested by issue opensearch-project#10970.

Resolves opensearch-project#13965
Resolves opensearch-project#10970

Signed-off-by: Andrew Ross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Meta Meta issue, not directly linked to a PR Other skip-changelog stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove or shorten the PR checklist [Discuss] Do not fail PRs on description non-compliance
5 participants