-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add NestedField Visit Method #13961
Conversation
Signed-off-by: luyuncheng <[email protected]>
❌ Gradle check result for e72e9b3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Having this same problem. NeuralQueryEnricher search processor does not support Nested Fields |
This PR is stalled because it has been open for 30 days with no activity. |
Hi @luyuncheng, I created a PR to fix the same issue and found there is duplicate PR. Are you still working at this PR? |
@zhichao-aws |
This PR is stalled because it has been open for 30 days with no activity. |
i use neural query in OpenSearch with nested field https://opensearch.org/docs/latest/search-plugins/semantic-search/#setting-a-default-model-on-an-index-or-field, but it can not calling model in search pipeline with
neural_query_enricher
processor like the doc shows.i think it is because NestedQueryBuilder do not support visit method like
boolean query
OpenSearch/server/src/main/java/org/opensearch/index/query/BoolQueryBuilder.java
Lines 432 to 439 in 581fcd2
it can not visit from processRequest like the following code do:
https://github.com/opensearch-project/neural-search/blob/2b21110be2d343e83f539e75104a8928522bf720/src/main/java/org/opensearch/neuralsearch/processor/NeuralQueryEnricherProcessor.java#L68-L75
BTW in #13837 i see it fixed many scenarios queries, but we still need
NestedQueryBuilder
to visit query builder.so this pr i added a visit method.