-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Remote Object managers and use them in orchestration from RemoteClusterStateService #13924
Create Remote Object managers and use them in orchestration from RemoteClusterStateService #13924
Conversation
❌ Gradle check result for 8cc0442: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 11ded3e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 9b53c30: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3ed4d14: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 74b1086: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shivansh Arora <[email protected]>
❌ Gradle check result for 74b1086: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13924-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 81fd0884ebb46414449f347f615924621cbff3c1
# Push it to GitHub
git push --set-upstream origin backport/backport-13924-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…teClusterStateService (opensearch-project#13924) * Create Remote Object managers and use them in orchestration from RemoteClusterStateService Signed-off-by: Shivansh Arora <[email protected]>
…teClusterStateService (#13924) (#14188) * Create Remote Object managers and use them in orchestration from RemoteClusterStateService Signed-off-by: Shivansh Arora <[email protected]> Co-authored-by: Shivansh Arora <[email protected]>
…teClusterStateService (opensearch-project#13924) (opensearch-project#14188) * Create Remote Object managers and use them in orchestration from RemoteClusterStateService Signed-off-by: Shivansh Arora <[email protected]> Co-authored-by: Shivansh Arora <[email protected]> Signed-off-by: kkewwei <[email protected]>
…teClusterStateService (opensearch-project#13924) * Create Remote Object managers and use them in orchestration from RemoteClusterStateService Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR is a follow up on #12190, where we split the global metadata uploaded in remote as multiple files. We received review from maintainers to split the
RemoteClusterStateService
into de-composable units for which we created #12881We have created new RemoteGlobalMetadataManager, RemoteIndexMetadataManager, RemoteManifestManager which manages the read and write of different RemoteObjects. RemoteClusterStateService leverages these managers to orchestrate the write and read of RemoteObjects to RemoteStore.
Additionally, metadata files uploaded with CODEC_V2 will not have
.dat
suffix. Our tree for metadata will look something like this:Related Issues
Resolves #12881
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.