Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] 13776: allow adding query parameters to RequestOptions #13778

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

oliverlockwood
Copy link
Contributor

Description

Allows adding query parameters to RequestOptions, e.g. to be able to set ?filter-path=<something> as documented in https://opensearch.org/docs/2.3/opensearch/common-parameters/#filtered-responses.

This is the same PR as #13777, but targeting the 2.x branch.

Related Issues

Resolves #13776.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request labels May 22, 2024
Copy link
Contributor

❌ Gradle check result for 9384163: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for fc0d014: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for abc8a8a: SUCCESS

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.36%. Comparing base (0dd892c) to head (8eb94f4).
Report is 298 commits behind head on 2.x.

Files Patch % Lines
...ain/java/org/opensearch/client/RequestOptions.java 62.50% 5 Missing and 1 partial ⚠️
...t/src/main/java/org/opensearch/client/Request.java 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13778      +/-   ##
============================================
+ Coverage     71.28%   71.36%   +0.07%     
- Complexity    60145    61359    +1214     
============================================
  Files          4957     5040      +83     
  Lines        282799   288500    +5701     
  Branches      41409    42148     +739     
============================================
+ Hits         201591   205875    +4284     
- Misses        64189    65277    +1088     
- Partials      17019    17348     +329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0 labels May 23, 2024
@reta
Copy link
Collaborator

reta commented May 31, 2024

@oliverlockwood could you please rebase against latest 2.x? thank you.

-  Fix bug highlighted by unit testing
-  Address code review comments
-  Run spotlessApply to satisfy formatting rules
-  Fix more queryParams->parameters cases
-  Apply code review feedback

Signed-off-by: Oliver Lockwood <[email protected]>
@oliverlockwood
Copy link
Contributor Author

@oliverlockwood could you please rebase against latest 2.x? thank you.

@reta I have now rebased this off the latest 2.x, squashed all my changes into one commit, and fixed the CHANGELOG.md conflict.

Please let me know if anything more is needed. Thanks.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

#11179

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

#13433
#13600

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

#13695

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

#13600
#11179

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

#13828
#13473

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 5, 2024

❌ Gradle check result for 8eb94f4: FAILURE

#11179

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ Gradle check result for 8eb94f4: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants