-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] 13776: allow adding query parameters to RequestOptions #13778
Conversation
❌ Gradle check result for 9384163: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for fc0d014: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #13778 +/- ##
============================================
+ Coverage 71.28% 71.36% +0.07%
- Complexity 60145 61359 +1214
============================================
Files 4957 5040 +83
Lines 282799 288500 +5701
Branches 41409 42148 +739
============================================
+ Hits 201591 205875 +4284
- Misses 64189 65277 +1088
- Partials 17019 17348 +329 ☔ View full report in Codecov by Sentry. |
@oliverlockwood could you please rebase against latest |
- Fix bug highlighted by unit testing - Address code review comments - Run spotlessApply to satisfy formatting rules - Fix more queryParams->parameters cases - Apply code review feedback Signed-off-by: Oliver Lockwood <[email protected]>
@reta I have now rebased this off the latest Please let me know if anything more is needed. Thanks. |
❌ Gradle check result for 8eb94f4: ABORTED Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8eb94f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8eb94f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8eb94f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8eb94f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8eb94f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8eb94f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…oject#13778) - Fix bug highlighted by unit testing - Address code review comments - Run spotlessApply to satisfy formatting rules - Fix more queryParams->parameters cases - Apply code review feedback Signed-off-by: Oliver Lockwood <[email protected]> Signed-off-by: kkewwei <[email protected]>
Description
Allows adding query parameters to RequestOptions, e.g. to be able to set
?filter-path=<something>
as documented in https://opensearch.org/docs/2.3/opensearch/common-parameters/#filtered-responses.This is the same PR as #13777, but targeting the 2.x branch.
Related Issues
Resolves #13776.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.