Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Introduce PluginMetadataClient #13712

Closed
wants to merge 1 commit into from

Conversation

fddattal
Copy link

Description

[Describe what this change achieves]

This PR introduces the PluginMetadataClient interface which abstractly exposes core metadata operations to plugins.

This pr is currently in draft. Tests are pending.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Reference RFC: #13274

Check List

  • [TODO] New functionality includes testing.
    • [TODO] All tests pass
  • [Y] New functionality has been documented.
    • [Y] New functionality has javadoc added
  • [N/A] API changes companion pull request created.
  • [TODO] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • [TODO] Commits are signed per the DCO using --signoff
  • [TODO] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [TODO] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 9d9e2dd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented May 16, 2024

Looking at this code, is the SdkAwarePlugin additional abstraction really necessary? What's the reason that it's not called MetadataPlugin instead?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jun 17, 2024
@fddattal fddattal closed this Jun 17, 2024
@fddattal
Copy link
Author

Update for posterity - We decided to move in another direction. More details on the RFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants