Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 12159 to 2.x #13681

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

vikasvb90
Copy link
Contributor

@vikasvb90 vikasvb90 commented May 15, 2024

Description

Backport of PR #12159

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vikasvb90 vikasvb90 force-pushed the backport-12159-to-2.x branch from 0351e49 to 62c7fd3 Compare May 15, 2024 12:05
Copy link
Contributor

✅ Gradle check result for 0351e49: SUCCESS

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 71.50838% with 102 lines in your changes are missing coverage. Please review.

Project coverage is 71.23%. Comparing base (0dd892c) to head (0351e49).
Report is 251 commits behind head on 2.x.

❗ Current head 0351e49 differs from pull request most recent head f8f5b22. Consider uploading reports for the commit f8f5b22 to get more accurate results

Files Patch % Lines
...opensearch/repositories/s3/S3RepositoryPlugin.java 0.00% 29 Missing ⚠️
...rg/opensearch/repositories/s3/S3BlobContainer.java 48.27% 6 Missing and 9 partials ⚠️
...epositories/s3/async/TransferSemaphoresHolder.java 80.00% 6 Missing and 5 partials ⚠️
...ch/repositories/s3/async/AsyncTransferManager.java 79.16% 9 Missing and 1 partial ⚠️
...arch/repositories/s3/async/SizeBasedBlockingQ.java 89.01% 7 Missing and 3 partials ⚠️
...h/repositories/s3/GenericStatsMetricPublisher.java 75.00% 8 Missing ⚠️
...earch/repositories/s3/async/AsyncPartsHandler.java 82.05% 4 Missing and 3 partials ⚠️
...va/org/opensearch/repositories/s3/S3BlobStore.java 50.00% 6 Missing ⚠️
...earch/index/store/RemoteSegmentStoreDirectory.java 0.00% 3 Missing ⚠️
...va/org/opensearch/index/store/RemoteDirectory.java 33.33% 0 Missing and 2 partials ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13681      +/-   ##
============================================
- Coverage     71.28%   71.23%   -0.06%     
- Complexity    60145    61208    +1063     
============================================
  Files          4957     5035      +78     
  Lines        282799   288185    +5386     
  Branches      41409    42109     +700     
============================================
+ Hits         201591   205281    +3690     
- Misses        64189    65579    +1390     
- Partials      17019    17325     +306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 62c7fd3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vikasvb90 vikasvb90 force-pushed the backport-12159-to-2.x branch from 62c7fd3 to 4dd1180 Compare May 15, 2024 13:30
Copy link
Contributor

❌ Gradle check result for 4dd1180: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vikasvb90 vikasvb90 force-pushed the backport-12159-to-2.x branch from 4dd1180 to 3b69797 Compare May 15, 2024 14:35
Copy link
Contributor

❌ Gradle check result for 3b69797: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vikasvb90 vikasvb90 force-pushed the backport-12159-to-2.x branch from 3b69797 to 0e98736 Compare May 15, 2024 15:31
Copy link
Contributor

❌ Gradle check result for 0e98736: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vikasvb90 vikasvb90 force-pushed the backport-12159-to-2.x branch from 0e98736 to f8f5b22 Compare May 15, 2024 16:55
Copy link
Contributor

❕ Gradle check result for f8f5b22: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@dblock dblock merged commit a95e31a into opensearch-project:2.x May 16, 2024
26 of 27 checks passed
@vikasvb90
Copy link
Contributor Author

Thanks @dblock for merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants