-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance tika document parsing tests #13618
Conversation
❌ Gradle check result for 7ee6045: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 810f3a9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Gradle check failing due to unrelated flaky test: #11979 |
❌ Gradle check result for 810f3a9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2dc3fcf
to
ddd4b56
Compare
❌ Gradle check result for 3bd9469: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2dc3fcf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Known flaky test: #13600 |
❌ Gradle check result for 3fcc4bc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9ae651e
to
ef62853
Compare
❌ Gradle check result for 9ae651e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ef62853: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@finnegancarroll we sadly have pretty flaky test suite now, fe this combination fails for me:
Please let |
Signed-off-by: Carroll <[email protected]>
Signed-off-by: Carroll <[email protected]>
Signed-off-by: Carroll <[email protected]>
Signed-off-by: Carroll <[email protected]>
Signed-off-by: Carroll <[email protected]>
Signed-off-by: Carroll <[email protected]>
Signed-off-by: Carroll <[email protected]>
ef62853
to
f0cc854
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13618 +/- ##
============================================
+ Coverage 71.42% 71.56% +0.14%
- Complexity 59978 61201 +1223
============================================
Files 4985 5059 +74
Lines 282275 287522 +5247
Branches 40946 41646 +700
============================================
+ Hits 201603 205759 +4156
- Misses 63999 64777 +778
- Partials 16673 16986 +313 ☔ View full report in Codecov by Sentry. |
Removed strict checksum validation for some additional files with locale dependent parsing. Ran for a couple hours and with all available locales in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better than what we have, @reta any objections?
* Update tika document parsing bwc tests. Signed-off-by: Carroll <[email protected]> * Skip sample tika files which do not parse consistently. Signed-off-by: Carroll <[email protected]> * Formatting for spotlessJavaCheck. Signed-off-by: Carroll <[email protected]> * Use fixed locale for consistent tika parsing. Signed-off-by: Carroll <[email protected]> * Move sha1 map to .checksums file. Signed-off-by: Carroll <[email protected]> * For locale dependant files do not verify contents with hash. Signed-off-by: Carroll <[email protected]> * Remove strict checksum validation for additional locale dependant files. Signed-off-by: Carroll <[email protected]> --------- Signed-off-by: Carroll <[email protected]> (cherry picked from commit f217270) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update tika document parsing bwc tests. * Skip sample tika files which do not parse consistently. * Formatting for spotlessJavaCheck. * Use fixed locale for consistent tika parsing. * Move sha1 map to .checksums file. * For locale dependant files do not verify contents with hash. * Remove strict checksum validation for additional locale dependant files. --------- (cherry picked from commit f217270) Signed-off-by: Carroll <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update tika document parsing bwc tests. Signed-off-by: Carroll <[email protected]> * Skip sample tika files which do not parse consistently. Signed-off-by: Carroll <[email protected]> * Formatting for spotlessJavaCheck. Signed-off-by: Carroll <[email protected]> * Use fixed locale for consistent tika parsing. Signed-off-by: Carroll <[email protected]> * Move sha1 map to .checksums file. Signed-off-by: Carroll <[email protected]> * For locale dependant files do not verify contents with hash. Signed-off-by: Carroll <[email protected]> * Remove strict checksum validation for additional locale dependant files. Signed-off-by: Carroll <[email protected]> --------- Signed-off-by: Carroll <[email protected]>
* Update tika document parsing bwc tests. Signed-off-by: Carroll <[email protected]> * Skip sample tika files which do not parse consistently. Signed-off-by: Carroll <[email protected]> * Formatting for spotlessJavaCheck. Signed-off-by: Carroll <[email protected]> * Use fixed locale for consistent tika parsing. Signed-off-by: Carroll <[email protected]> * Move sha1 map to .checksums file. Signed-off-by: Carroll <[email protected]> * For locale dependant files do not verify contents with hash. Signed-off-by: Carroll <[email protected]> * Remove strict checksum validation for additional locale dependant files. Signed-off-by: Carroll <[email protected]> --------- Signed-off-by: Carroll <[email protected]>
Description
Enhance tika document parsing tests by validating output against current version.
Related Issues
Resolves "Improve the validation on TikaDocTests #12887"
Check List
New functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.