Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set INDICES_MAX_CLAUSE_COUNT dynamically #13568

Merged
merged 12 commits into from
Jun 18, 2024
Merged

Set INDICES_MAX_CLAUSE_COUNT dynamically #13568

merged 12 commits into from
Jun 18, 2024

Conversation

harshavamsi
Copy link
Contributor

@harshavamsi harshavamsi commented May 6, 2024 •
edited
Loading

Description

Changes the INDICES_MAX_CLAUSE_COUNT_SETTING to be dynamic instead of being static.

This PR is virtually identical to #1527, but there was earlier push back around making this an updateable dynamic setting due to the assumption that users would abuse this setting rather than optimize their underlying query. Lucene has since updated the way the clause counts work and this is now enforced at the indexSearcher level -- https://issues.apache.org/jira/browse/LUCENE-8811.

More info can be found in #12549 around the motivation for this change, but I ended up raising a PR to make a simple dynamic setting.

Related Issues

Resolves #1526 #12549

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@harshavamsi
Set INDICES_MAX_CLAUSE_COUNT dynamically
dd140e2 
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

❌ Gradle check result for dd140e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi harshavamsi force-pushed the dynamic_max_clause branch from 6ccaa23 to 28d5525 Compare May 7, 2024 00:24
@harshavamsi harshavamsi force-pushed the dynamic_max_clause branch from 28d5525 to 4ff1d13 Compare May 7, 2024 00:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

❌ Gradle check result for 28d5525: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi
Changelog
6321ca8 
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@harshavamsi harshavamsi marked this pull request as ready for review May 7, 2024 00:58
reta
reta reviewed Jun 13, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@reta
Copy link
Collaborator

reta commented Jun 13, 2024

2.15.0 has sailed away, targeting this change to 2.16.0

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for cd92a9b: SUCCESS

@github-actions github-actions bot added the v3.0.0 Issues and PRs related to version 3.0.0 label Jun 13, 2024
@harshavamsi
Fix changelog
e715516 
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b221209: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi harshavamsi mentioned this pull request Jun 13, 2024
Closed
4 tasks
This was referenced Jun 13, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e715516: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi
Copy link
Contributor Author

Opened https://github.com/opensearch-project/documentation-website/pull/7391/files

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jun 14, 2024
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Jun 14, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e715516: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi
Copy link
Contributor Author

❌ Gradle check result for e715516: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#14300
#12651
@msfroh can we merge?

This was referenced Jun 17, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for e715516: SUCCESS

@msfroh msfroh merged commit c5c6024 into opensearch-project:main Jun 18, 2024
32 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@github-actions
Set INDICES_MAX_CLAUSE_COUNT dynamically (#13568)
231daad 
---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
(cherry picked from commit c5c6024)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 18, 2024
Merged
@harshavamsi harshavamsi deleted the dynamic_max_clause branch June 18, 2024 18:38
dblock pushed a commit that referenced this pull request Jun 19, 2024
@opensearch-trigger-bot @github-actions
Set INDICES_MAX_CLAUSE_COUNT dynamically (#13568) (#14436)
8148e4d 
---------


(cherry picked from commit c5c6024)

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi added a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
@harshavamsi
Set INDICES_MAX_CLAUSE_COUNT dynamically (opensearch-project#13568)
d4d8666 
---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @kkewwei
Set INDICES_MAX_CLAUSE_COUNT dynamically (opensearch-project#13568) (o…
8b4619b 
…pensearch-project#14436)

---------

(cherry picked from commit c5c6024)

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2024
Merged
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@harshavamsi
Set INDICES_MAX_CLAUSE_COUNT dynamically (opensearch-project#13568)
7aaee0c 
---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@msfroh msfroh mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainankitk jainankitk jainankitk approved these changes

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@peternied peternied Awaiting requested review from peternied

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v2.16.0 Issues and PRs related to version 2.16.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic max boolean clause counts
4 participants
@harshavamsi @reta @msfroh @jainankitk