Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support wildcard/regex for indices param in _remotestore/_restore (#8922) #13527

Merged

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented May 3, 2024

  • Support wildcard/regex for indices param in _remotestore/_restore

Signed-off-by: bansvaru [email protected]
(cherry picked from commit 29ebd80)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ensearch-project#8922)

* Support wildcard/regex for indices param in _remotestore/_restore

Signed-off-by: Varun Bansal <[email protected]>
(cherry picked from commit 29ebd80)
@linuxpi linuxpi force-pushed the backport/backport-8922-to-2.x branch from 60d74ed to 9d4efbb Compare May 3, 2024 10:04
Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for 60d74ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peternied peternied changed the title Support wildcard/regex for indices param in _remotestore/_restore (#8922) [Backport 2.x] Support wildcard/regex for indices param in _remotestore/_restore (#8922) May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

❕ Gradle check result for 9d4efbb: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 77.19298% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 71.19%. Comparing base (0dd892c) to head (9d4efbb).
Report is 225 commits behind head on 2.x.

Files Patch % Lines
...in/java/org/opensearch/common/util/IndexUtils.java 84.61% 4 Missing and 4 partials ⚠️
...arch/index/recovery/RemoteStoreRestoreService.java 0.00% 4 Missing ⚠️
...ava/org/opensearch/snapshots/SnapshotsService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13527      +/-   ##
============================================
- Coverage     71.28%   71.19%   -0.09%     
- Complexity    60145    61132     +987     
============================================
  Files          4957     5027      +70     
  Lines        282799   287538    +4739     
  Branches      41409    42038     +629     
============================================
+ Hits         201591   204722    +3131     
- Misses        64189    65539    +1350     
- Partials      17019    17277     +258     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit f77b971 into opensearch-project:2.x May 3, 2024
29 checks passed
@linuxpi linuxpi deleted the backport/backport-8922-to-2.x branch May 3, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants