-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TestIssueLogging on flaky test - org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown #13489
Conversation
❌ Gradle check result for 6ba7690: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@linuxpi this links to an ES bug? Can you explain what you're trying to do please? |
…eStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown Signed-off-by: Varun Bansal <[email protected]>
6ba7690
to
2b98296
Compare
❌ Gradle check result for 2b98296: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bansal <[email protected]>
❌ Gradle check result for e357656: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bansal <[email protected]>
❌ Gradle check result for bb3c707: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13489 +/- ##
============================================
+ Coverage 71.42% 71.62% +0.20%
- Complexity 59978 61105 +1127
============================================
Files 4985 5051 +66
Lines 282275 287119 +4844
Branches 40946 41602 +656
============================================
+ Hits 201603 205658 +4055
- Misses 63999 64467 +468
- Partials 16673 16994 +321 ☔ View full report in Codecov by Sentry. |
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreRestoreIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is to elastic/elasticsearch, it should be opensearch-project/OpenSearch
Signed-off-by: Varun Bansal <[email protected]>
thanks @dblock for catching this. i thought you were referring to the link in description. I've corrected the link now |
❌ Gradle check result for e89dbdc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@linuxpi Noticed your empty commit to retrigger gradle check. You can do a |
❌ Gradle check result for f35bc18: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f35bc18
to
c4ff6de
Compare
Signed-off-by: Varun Bansal <[email protected]>
c4ff6de
to
e1466b5
Compare
@dblock can you check if the PR looks good now? |
…eStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown (opensearch-project#13489) * add TestIssueLogging on flaky test - org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown Signed-off-by: Varun Bansal <[email protected]>
…eStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown (opensearch-project#13489) * add TestIssueLogging on flaky test - org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown Signed-off-by: Varun Bansal <[email protected]>
…eStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown (opensearch-project#13489) * add TestIssueLogging on flaky test - org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown Signed-off-by: Varun Bansal <[email protected]>
Description
org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown
is not repro-able in local environment even after 5k iteration.Related Issues
Relates to #11085
Check List
New functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.