Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TestIssueLogging on flaky test - org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown #13489

Merged

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented May 1, 2024

Description

  • Adds test logging to debug flaky test.
  • Flaky Test org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown is not repro-able in local environment even after 5k iteration.
  • To be able to understand the root cause of flakyness, we need to get trace logging when this test fails.
  • Changes in the PR will ensure whenever this test fails in any PR gradle check, we get trace logging to be able to find the root cause and fix

Related Issues

Relates to #11085

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented May 1, 2024

❌ Gradle check result for 6ba7690: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented May 1, 2024

@linuxpi this links to an ES bug? Can you explain what you're trying to do please?

@linuxpi
Copy link
Collaborator Author

linuxpi commented May 2, 2024

@linuxpi this links to an ES bug? Can you explain what you're trying to do please?

@dblock this is related to a flaky bug - #11085 . We are enabling trace logging for test failures in PR builds to get to the root cause of the flakyness

…eStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown

Signed-off-by: Varun Bansal <[email protected]>
@linuxpi linuxpi force-pushed the test-logging-remote-store-it branch from 6ba7690 to 2b98296 Compare May 2, 2024 09:56
@linuxpi linuxpi self-assigned this May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for 2b98296: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Varun Bansal <[email protected]>
Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for e357656: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Varun Bansal <[email protected]>
Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for bb3c707: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 3, 2024

✅ Gradle check result for cbae09f: SUCCESS

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.62%. Comparing base (b15cb0c) to head (e1466b5).
Report is 264 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13489      +/-   ##
============================================
+ Coverage     71.42%   71.62%   +0.20%     
- Complexity    59978    61105    +1127     
============================================
  Files          4985     5051      +66     
  Lines        282275   287119    +4844     
  Branches      40946    41602     +656     
============================================
+ Hits         201603   205658    +4055     
- Misses        63999    64467     +468     
- Partials      16673    16994     +321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is to elastic/elasticsearch, it should be opensearch-project/OpenSearch

Signed-off-by: Varun Bansal <[email protected]>
@linuxpi
Copy link
Collaborator Author

linuxpi commented May 4, 2024

The link is to elastic/elasticsearch, it should be opensearch-project/OpenSearch

thanks @dblock for catching this. i thought you were referring to the link in description. I've corrected the link now

Copy link
Contributor

github-actions bot commented May 4, 2024

❌ Gradle check result for e89dbdc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented May 4, 2024

@linuxpi Noticed your empty commit to retrigger gradle check. You can do a git commit --amend and force push with -f to avoid that.

Copy link
Contributor

github-actions bot commented May 4, 2024

❌ Gradle check result for f35bc18: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@linuxpi
Copy link
Collaborator Author

linuxpi commented May 6, 2024

@linuxpi Noticed your empty commit to retrigger gradle check. You can do a git commit --amend and force push with -f to avoid that.

Thanks for the suggestion @dblock . Was trying to avoid force pushes but i guess just amending last commit might not be an issue

@linuxpi linuxpi force-pushed the test-logging-remote-store-it branch from f35bc18 to c4ff6de Compare May 6, 2024 05:05
Copy link
Contributor

github-actions bot commented May 6, 2024

✅ Gradle check result for c4ff6de: SUCCESS

Signed-off-by: Varun Bansal <[email protected]>
@linuxpi linuxpi force-pushed the test-logging-remote-store-it branch from c4ff6de to e1466b5 Compare May 6, 2024 12:02
Copy link
Contributor

github-actions bot commented May 6, 2024

✅ Gradle check result for e1466b5: SUCCESS

@linuxpi
Copy link
Collaborator Author

linuxpi commented May 6, 2024

@dblock can you check if the PR looks good now?

@sachinpkale sachinpkale merged commit 6b6a0a2 into opensearch-project:main May 7, 2024
28 checks passed
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
…eStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown (opensearch-project#13489)

* add TestIssueLogging on flaky test - org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown

Signed-off-by: Varun Bansal <[email protected]>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
…eStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown (opensearch-project#13489)

* add TestIssueLogging on flaky test - org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown

Signed-off-by: Varun Bansal <[email protected]>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…eStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown (opensearch-project#13489)

* add TestIssueLogging on flaky test - org.opensearch.remotestore.RemoteStoreRestoreIT.testRTSRestoreWithNoDataPostRefreshPrimaryReplicaDown

Signed-off-by: Varun Bansal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants