-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip running gradle checks on release notes #13477
Conversation
Signed-off-by: Sayali Gaikawad <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13477 +/- ##
============================================
+ Coverage 71.42% 71.47% +0.04%
- Complexity 59978 60975 +997
============================================
Files 4985 5050 +65
Lines 282275 286804 +4529
Branches 40946 41550 +604
============================================
+ Hits 201603 204979 +3376
- Misses 63999 64847 +848
- Partials 16673 16978 +305 ☔ View full report in Codecov by Sentry. |
@kotwanikunal @reta Can I merge this as is or do you have recommendations on more things to add under |
|
I think the intention was to cover larger scope of changes that do not require check runs, leaving it up to @kotwanikunal since he was working on it. |
Signed-off-by: Sayali Gaikawad <[email protected]>
Done! |
❌ Gradle check result for 8e0d3ff: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit 1765e20) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Added backport 2x label. @rishabh6788 @bbarani leaving upto you if you want this in 2.14 branch. Might help save sometime (actually hours) for things like release notes and .md changes. |
@rishabh6788 Lets backport this to 2.14 branch. |
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit 1765e20) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 1765e20) Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 1765e20) Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Description
Running gradle check on release notes does not provide any value but instead adds a huge overhead while merging PRs during release cycle. Had to wait for 2+ hours during 2.13.0 while creating RC as release notes if one of the entrance criteria to start the release window.
Please let me know if we should include all
.md
files as well.github
directory to this list as well.Related Issues
opensearch-project/opensearch-build#4562
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.