-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to macos-13 runner for precommit and assemble github actions due to macos-latest is now arm64 #13412
Switch to macos-13 runner for precommit and assemble github actions due to macos-latest is now arm64 #13412
Conversation
…now arm64 Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
❌ Gradle check result for 7d43a68: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Looks like assemble is failing on these? |
The way to install docker has been limited on M123 apple silicon. Thanks. |
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
As per the conversation on this issue actions/runner-images#9254 looks like docker is not supported on M1 runners.Something to note once we decide to upgrade |
macos-14 has x64 version but right now their docs website and their github readme is conflicting with each other on the tag naming. Will keep macos-13 for now as that is 100% x64. Thanks. |
Signed-off-by: Peter Zhu <[email protected]>
❕ Gradle check result for d0ee653: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@peterzhuamazon can we have an issue to switch to macos-latest in the future? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13412 +/- ##
============================================
+ Coverage 71.42% 71.50% +0.08%
- Complexity 59978 60823 +845
============================================
Files 4985 5045 +60
Lines 282275 286068 +3793
Branches 40946 41431 +485
============================================
+ Hits 201603 204547 +2944
- Misses 63999 64604 +605
- Partials 16673 16917 +244 ☔ View full report in Codecov by Sentry. |
❕ Gradle check result for 41854a5: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
…ue to macos-latest is now arm64 (#13412) * Switch to macos-13 for precommit and assemble due to macos-latest is now arm64 Signed-off-by: Peter Zhu <[email protected]> * Update changelog Signed-off-by: Peter Zhu <[email protected]> * Add action Signed-off-by: Peter Zhu <[email protected]> * Add action Signed-off-by: Peter Zhu <[email protected]> * more changes Signed-off-by: Peter Zhu <[email protected]> * Remove colima start command as action already start it Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 207bbad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ue to macos-latest is now arm64 (#13412) (#13420) * Switch to macos-13 for precommit and assemble due to macos-latest is now arm64 * Update changelog * Add action * Add action * more changes * Remove colima start command as action already start it --------- (cherry picked from commit 207bbad) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Switch to macos-13 runner for precommit and assemble github actions due to macos-latest is now arm64
Related Issues
#13417
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.