-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take shallow copy snapshot only when remote store compatibility mode is STRICT #13309
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13309 +/- ##
============================================
+ Coverage 71.42% 71.53% +0.11%
- Complexity 59978 60777 +799
============================================
Files 4985 5044 +59
Lines 282275 285683 +3408
Branches 40946 41369 +423
============================================
+ Hits 201603 204365 +2762
- Misses 63999 64469 +470
- Partials 16673 16849 +176 ☔ View full report in Codecov by Sentry. |
1e351a9
to
228bef4
Compare
❌ Gradle check result for 228bef4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test #11374 |
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
...nalClusterTest/java/org/opensearch/remotemigration/RemoteStoreMigrationSettingsUpdateIT.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lakshya Taragi <[email protected]>
228bef4
to
aa7df1a
Compare
Signed-off-by: Lakshya Taragi <[email protected]>
aa7df1a
to
6981075
Compare
…#13309) Signed-off-by: Lakshya Taragi <[email protected]> (cherry picked from commit 5bf522c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ress (#13309) (#13382) (cherry picked from commit 5bf522c) Signed-off-by: Lakshya Taragi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
createSnapshot
operation, if theremote_store_index_shallow_copy
setting is found to betrue
in the repository metadata settings but the cluster is in theMIXED
compatibility mode, we override this setting tofalse
. Thus, we do not honor the shallow snapshot setting and create full snapshots only.Related Issues
Resolves #13101
Check List
New functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.