Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take shallow copy snapshot only when remote store compatibility mode is STRICT #13309

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Apr 19, 2024

Description

  • This change ensures that when under remote-store/docrep migration, shallow snapshots are not taken as both remote-backed and non-remote-backed indices are present.
  • For the createSnapshot operation, if the remote_store_index_shallow_copy setting is found to be true in the repository metadata settings but the cluster is in the MIXED compatibility mode, we override this setting to false. Thus, we do not honor the shallow snapshot setting and create full snapshots only.

Related Issues

Resolves #13101

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Snapshots labels Apr 19, 2024
@ltaragi ltaragi added skip-changelog and removed enhancement Enhancement or improvement to existing feature or request Storage:Snapshots labels Apr 19, 2024
Copy link
Contributor

✅ Gradle check result for 1e351a9: SUCCESS

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.53%. Comparing base (b15cb0c) to head (aa7df1a).
Report is 214 commits behind head on main.

❗ Current head aa7df1a differs from pull request most recent head 6981075. Consider uploading reports for the commit 6981075 to get more accurate results

Files Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13309      +/-   ##
============================================
+ Coverage     71.42%   71.53%   +0.11%     
- Complexity    59978    60777     +799     
============================================
  Files          4985     5044      +59     
  Lines        282275   285683    +3408     
  Branches      40946    41369     +423     
============================================
+ Hits         201603   204365    +2762     
- Misses        63999    64469     +470     
- Partials      16673    16849     +176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltaragi ltaragi self-assigned this Apr 23, 2024
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Snapshots labels Apr 23, 2024
@ltaragi ltaragi marked this pull request as ready for review April 23, 2024 13:30
Copy link
Contributor

❌ Gradle check result for 228bef4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ltaragi
Copy link
Contributor Author

ltaragi commented Apr 24, 2024

❌ Gradle check result for 228bef4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.indices.IndicesRequestCacheIT.testProfileDisableCache {p0={"search.concurrent_segment_search.enabled":"true"}}

Flaky test #11374

Copy link
Contributor

✅ Gradle check result for aa7df1a: SUCCESS

Signed-off-by: Lakshya Taragi <[email protected]>
Copy link
Contributor

✅ Gradle check result for 6981075: SUCCESS

@gbbafna gbbafna merged commit 5bf522c into opensearch-project:main Apr 25, 2024
26 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Apr 25, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2024
…#13309)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 5bf522c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Apr 25, 2024
…ress (#13309) (#13382)

(cherry picked from commit 5bf522c)

Signed-off-by: Lakshya Taragi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Snapshots
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Remote Store] Take shallow copy snapshot only when remote store compatibility mode is STRICT
3 participants