-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstracting outbound side of transport #13293
Abstracting outbound side of transport #13293
Conversation
❕ Gradle check result for 0a9c4d8: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13293 +/- ##
============================================
+ Coverage 71.42% 71.52% +0.10%
- Complexity 59978 61039 +1061
============================================
Files 4985 5054 +69
Lines 282275 287150 +4875
Branches 40946 41607 +661
============================================
+ Hits 201603 205373 +3770
- Misses 63999 64813 +814
- Partials 16673 16964 +291 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/transport/OutboundHandler.java
Outdated
Show resolved
Hide resolved
9e629ae
to
0ab2aec
Compare
❌ Gradle check result for 9e629ae: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 0ab2aec: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for c904eda: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/test/java/org/opensearch/transport/InboundDecoderTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/transport/InboundDecoderTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/transport/InboundDecoderTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Vacha Shah <[email protected]>
server/src/test/java/org/opensearch/transport/InboundHandlerTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/transport/TransportLoggerTests.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 0a7c0a3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VachaShah pefrect, thank you! @dblock mind taking a look please, thank you?
Looks great, let's merge it. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13293-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 14f1c43c108f378b13d109ade364216c082fb858
# Push it to GitHub
git push --set-upstream origin backport/backport-13293-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@VachaShah manual backport pls :( |
* Abstracting outbound side of transport Signed-off-by: Vacha Shah <[email protected]> * Making outbound handler protocol dependent via inbound handler Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit Signed-off-by: Vacha Shah <[email protected]> * Cleaning up code Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Cleaning up Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Abstracting InboundHandlerTests Signed-off-by: Vacha Shah <[email protected]> * Abstracting TransportLoggerTests Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]>
|
* Abstracting outbound side of transport * Making outbound handler protocol dependent via inbound handler * Fixing precommit * Addressing comments * Fixing precommit * Cleaning up code * Addressing comments * Cleaning up * Addressing comments * Abstracting InboundHandlerTests * Abstracting TransportLoggerTests --------- Signed-off-by: Vacha Shah <[email protected]>
* Abstracting outbound side of transport Signed-off-by: Vacha Shah <[email protected]> * Making outbound handler protocol dependent via inbound handler Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit Signed-off-by: Vacha Shah <[email protected]> * Cleaning up code Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Cleaning up Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Abstracting InboundHandlerTests Signed-off-by: Vacha Shah <[email protected]> * Abstracting TransportLoggerTests Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]>
* Abstracting outbound side of transport Signed-off-by: Vacha Shah <[email protected]> * Making outbound handler protocol dependent via inbound handler Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit Signed-off-by: Vacha Shah <[email protected]> * Cleaning up code Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Cleaning up Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Abstracting InboundHandlerTests Signed-off-by: Vacha Shah <[email protected]> * Abstracting TransportLoggerTests Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]>
Description
Coming from #13178 (comment) and as a next step to #12967, abstracting and adding support for multiple protocols on outbound side of transport.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Part of #10684
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.