-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Abstract out remote segment garbage collection logic #13221
base: main
Are you sure you want to change the base?
[Remote Store] Abstract out remote segment garbage collection logic #13221
Conversation
Signed-off-by: Sachin Kale <[email protected]>
Compatibility status:Checks if related components are compatible with change cc805f9 Incompatible componentsSkipped componentsCompatible components |
❌ Gradle check result for cc805f9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for cc805f9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
/** | ||
* Called on skipping the garbage collection | ||
*/ | ||
void onSkip(String reason); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a better contract would be shouldGarbageCollect() that returns a boolean. We can add additional safety constraints explicitly
This PR is stalled because it has been open for 30 days with no activity. |
Description
RemoteStoreRefreshListener
and has a fixed logic where the deletion is triggered post commit.RemoteStoreRefreshListener
.Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.