-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Apache Lucene 9.11.0-snapshot-fb97840 #13195
Update to Apache Lucene 9.11.0-snapshot-fb97840 #13195
Conversation
❌ Gradle check result for 583ffbf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change a864dee Incompatible componentsIncompatible components: [https://github.com/opensearch-project/index-management.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
583ffbf
to
cbabd8c
Compare
❌ Gradle check result for cbabd8c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Andriy Redko <[email protected]>
cbabd8c
to
a864dee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13195 +/- ##
============================================
+ Coverage 71.42% 71.57% +0.15%
- Complexity 59978 60727 +749
============================================
Files 4985 5039 +54
Lines 282275 285338 +3063
Branches 40946 41327 +381
============================================
+ Hits 201603 204230 +2627
- Misses 63999 64255 +256
- Partials 16673 16853 +180 ☔ View full report in Codecov by Sentry. |
This reverts commit 39ac2df.
url mavenSnapshotRepoUrl | ||
} | ||
} | ||
def repos = project.getRepositories(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reta Why did we need to make these changes? It looks like it caused issues in the download workflow [1] for other PRs.
./gradlew :server:japicmp
...
FAILURE: Build failed with an exception.
* What went wrong:
Could not determine the dependencies of task ':server:downloadSnapshot'.
> Could not resolve all task dependencies for configuration ':server:snapshotArtifact'.
> Could not find org.apache.lucene:lucene-core:9.11.0-snapshot-fb[97](https://github.com/opensearch-project/OpenSearch/actions/runs/8693672822/job/23846998626?pr=12812#step:4:100)840.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/org/apache/lucene/lucene-core/9.11.0-snapshot-fb97840/lucene-core-9.11.0-snapshot-fb97840.pom
- https://aws.oss.sonatype.org/content/repositories/snapshots/org/apache/lucene/lucene-core/9.11.0-snapshot-fb97840/lucene-core-9.11.0-snapshot-fb97840.pom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peternied the change was supposed to fix exactly that: the issue I run into was that that snapshot tasks tries to download opensearch deps from the https://aws.oss.sonatype.org/
whereas it should not since it has to use another repo. The change adds the https://aws.oss.sonatype.org/
as exclusive for org.opensearch
so it seemed to help but not entirely, I will take a look shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'm curious if the source for the artifacts changed. We have a myriad of changes [1] with hard to predict downstream effects, but this seemed like a new source or at least a source we haven't seen create friction before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'm curious if the source for the artifacts changed
The Apache Lucene snapshots are coming from different place (RepositoriesSetupPlugin
): https://ci.opensearch.org/ci/dbc/snapshots/lucene/
, but this seemed like a new source or at least a source we haven't seen create friction before.
Correct, but I think it is scoped only to japicmp
supporting tasks we've added (since we've been modifying repositories on the fly).
Description
Update to Apache Lucene 9.11.0-snapshot-fb97840
Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.