Finish contributing updates; thanks @acarbonetto #12981

stephen-crawford · 2024-03-29T20:42:03Z

Description

I was going over old PRs and found this one which just needed a little help over the finish line

If someone could add skip-changelog that would be appreciated.

Related Issues

Check List

~~New functionality includes testing.~~
- ~~All tests pass~~
New functionality has been documented.
- ~~New functionality has javadoc added~~
~~Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)~~
Commits are signed per the DCO using --signoff
~~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~~
~~Public documentation issue/PR created~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <[email protected]>

github-actions · 2024-03-29T21:05:12Z

Compatibility status:

Checks if related components are compatible with change aa45cda

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

dblock

There'a a lot of duplication with the content in developer guide, we should just add enough that links to it.

CONTRIBUTING.md

github-actions · 2024-03-29T21:29:51Z

✅ Gradle check result for 576a56e: SUCCESS

Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>

github-actions · 2024-04-04T14:10:32Z

❌ Gradle check result for 3bef242: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-04T14:13:12Z

❌ Gradle check result for 4750e99: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-04T14:18:10Z

❌ Gradle check result for b82607a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-04T14:18:56Z

❌ Gradle check result for c10c569: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-04T14:32:37Z

❌ Gradle check result for ef2ed75: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-04T14:32:50Z

❌ Gradle check result for 2820836: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

stephen-crawford · 2024-04-04T14:47:03Z

This is just a documentation change so I don't think the failure is related at all. @owaiskazi19 would you be able to approve? Thank you

owaiskazi19 · 2024-04-04T15:55:06Z

This is just a documentation change so I don't think the failure is related at all. @owaiskazi19 would you be able to approve? Thank you

Let's wait for the gradle check to pass. I just triggered it again.

github-actions · 2024-04-04T16:17:54Z

❌ Gradle check result for ef2ed75: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

owaiskazi19 · 2024-04-04T16:37:35Z

@scrawfor99 did you rebase your changes with latest main?

github-actions · 2024-04-04T17:06:08Z

❌ Gradle check result for ef2ed75: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-04T17:55:12Z

✅ Gradle check result for aa45cda: SUCCESS

@acarbonetto

* Finish contributing updates; thanks @acarbonetto Signed-off-by: Stephen Crawford <[email protected]> * Fix indenting Signed-off-by: Stephen Crawford <[email protected]> * Readd build failure notes Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING with review tips Signed-off-by: Andrew Carbonetto <[email protected]> * Update CONTRIBUTING with review tips Signed-off-by: Andrew Carbonetto <[email protected]> * Update contributing comment for review comment Signed-off-by: Andrew Carbonetto <[email protected]> * Fix contruibuting doc Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: Owais Kazi <[email protected]> (cherry picked from commit 19d6c5c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@acarbonetto

* Finish contributing updates; thanks @acarbonetto * Fix indenting * Readd build failure notes * Update CONTRIBUTING with review tips * Update CONTRIBUTING with review tips * Update contributing comment for review comment * Fix contruibuting doc * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md --------- (cherry picked from commit 19d6c5c) Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: Owais Kazi <[email protected]>

@acarbonetto

…12981) * Finish contributing updates; thanks @acarbonetto Signed-off-by: Stephen Crawford <[email protected]> * Fix indenting Signed-off-by: Stephen Crawford <[email protected]> * Readd build failure notes Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING with review tips Signed-off-by: Andrew Carbonetto <[email protected]> * Update CONTRIBUTING with review tips Signed-off-by: Andrew Carbonetto <[email protected]> * Update contributing comment for review comment Signed-off-by: Andrew Carbonetto <[email protected]> * Fix contruibuting doc Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>

peternied · 2024-04-25T21:09:16Z

@scrawfor99 I think there was a bad merge conflict - it looks like this PR deleted the contribution [1] by @reta. Could you please restore the Troubleshooting Failing Builds section?

[1] Update Github pull request template to have a task for inspecting failing checks #10751

Finish contributing updates; thanks @acarbonetto

576a56e

Signed-off-by: Stephen Crawford <[email protected]>

stephen-crawford added 2 commits March 29, 2024 16:43

Fix indenting

79f03af

Signed-off-by: Stephen Crawford <[email protected]>

Readd build failure notes

cc96f6b

Signed-off-by: Stephen Crawford <[email protected]>

dblock requested changes Mar 29, 2024

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

CONTRIBUTING.md Outdated Show resolved Hide resolved

CONTRIBUTING.md Outdated Show resolved Hide resolved

stephen-crawford and others added 8 commits April 4, 2024 09:41

Update CONTRIBUTING.md

4750e99

Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>

Update CONTRIBUTING.md

c10c569

Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>

Update CONTRIBUTING.md

3bef242

Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>

Update CONTRIBUTING.md

b82607a

Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>

Update CONTRIBUTING.md

610d544

Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>

Update CONTRIBUTING.md

3160181

Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>

Update CONTRIBUTING.md

2820836

Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>

Update CONTRIBUTING.md

ef2ed75

Co-authored-by: Owais Kazi <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>

Merge branch 'opensearch-project:main' into finishPRHelpDoc

aa45cda

owaiskazi19 approved these changes Apr 5, 2024

View reviewed changes

owaiskazi19 merged commit 19d6c5c into opensearch-project:main Apr 5, 2024
31 checks passed

owaiskazi19 added the backport 2.x Backport to 2.x branch label Apr 5, 2024

opensearch-trigger-bot bot mentioned this pull request Apr 5, 2024

[Backport 2.x] Finish contributing updates; thanks @acarbonetto #13088

Merged

stephen-crawford mentioned this pull request Apr 26, 2024

Restore deleted section of Contributing.md #13415

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Finish contributing updates; thanks @acarbonetto #12981

Finish contributing updates; thanks @acarbonetto #12981

stephen-crawford commented Mar 29, 2024 •

edited

Loading

github-actions bot commented Mar 29, 2024 •

edited

Loading

dblock left a comment

github-actions bot commented Mar 29, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

stephen-crawford commented Apr 4, 2024

owaiskazi19 commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

owaiskazi19 commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

peternied commented Apr 25, 2024

Finish contributing updates; thanks @acarbonetto #12981

Finish contributing updates; thanks @acarbonetto #12981

Conversation

stephen-crawford commented Mar 29, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Mar 29, 2024 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

dblock left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 29, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

stephen-crawford commented Apr 4, 2024

owaiskazi19 commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

owaiskazi19 commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

peternied commented Apr 25, 2024

stephen-crawford commented Mar 29, 2024 •

edited

Loading

github-actions bot commented Mar 29, 2024 •

edited

Loading