Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Allow setting KEYSTORE_PASSWORD through env variable (#12865) #12949

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Mar 27, 2024

Backport #12865 to 2.x

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Compatibility status:

Checks if related components are compatible with change c061f77

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git]

@reta
Copy link
Collaborator

reta commented Mar 27, 2024

@cwperks could you please push DCO fix? thank you

Copy link
Contributor

❌ Gradle check result for 1a8a6a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks cwperks force-pushed the backport-12865-to-2.x branch from 1a8a6a2 to c061f77 Compare March 27, 2024 20:33
@cwperks
Copy link
Member Author

cwperks commented Mar 27, 2024

@cwperks could you please push DCO fix? thank you

Fixed.

@reta reta self-requested a review March 27, 2024 20:36
Copy link
Contributor

❌ Gradle check result for c061f77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Mar 27, 2024

❌ Gradle check result for c061f77: FAILURE

#6542

Copy link
Contributor

❕ Gradle check result for c061f77: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.classMethod

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.21%. Comparing base (0dd892c) to head (c061f77).
Report is 96 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12949      +/-   ##
============================================
- Coverage     71.28%   71.21%   -0.07%     
- Complexity    60145    60447     +302     
============================================
  Files          4957     4985      +28     
  Lines        282799   284462    +1663     
  Branches      41409    41595     +186     
============================================
+ Hits         201591   202580     +989     
- Misses        64189    64778     +589     
- Partials      17019    17104      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 2d0aed1 into opensearch-project:2.x Mar 27, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants