Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Perform buildAggregation concurrently and partially support composite aggs #12940

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Mar 27, 2024

Backport 2.x for #12697

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
    - [] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jed326
Copy link
Collaborator Author

jed326 commented Mar 27, 2024

@reta Here is the 2.x backport for #12697. Thanks!

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 36d14e4

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❕ Gradle check result for 36d14e4: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting
      1 org.opensearch.index.ShardIndexingPressureSettingsIT.classMethod
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 63.82979% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 71.09%. Comparing base (0dd892c) to head (36d14e4).
Report is 93 commits behind head on 2.x.

Files Patch % Lines
.../search/aggregations/BucketCollectorProcessor.java 76.47% 1 Missing and 3 partials ⚠️
...search/aggregations/GlobalAggCollectorManager.java 20.00% 3 Missing and 1 partial ⚠️
...rch/aggregations/NonGlobalAggCollectorManager.java 20.00% 3 Missing and 1 partial ⚠️
...ket/terms/GlobalOrdinalsStringTermsAggregator.java 83.33% 1 Missing and 1 partial ⚠️
...arch/aggregations/AggregationCollectorManager.java 50.00% 0 Missing and 1 partial ⚠️
.../bucket/composite/CompositeAggregationFactory.java 0.00% 1 Missing ⚠️
.../org/opensearch/search/internal/SearchContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12940      +/-   ##
============================================
- Coverage     71.28%   71.09%   -0.20%     
- Complexity    60145    60364     +219     
============================================
  Files          4957     4985      +28     
  Lines        282799   284458    +1659     
  Branches      41409    41594     +185     
============================================
+ Hits         201591   202230     +639     
- Misses        64189    65165     +976     
- Partials      17019    17063      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 795d868 into opensearch-project:2.x Mar 27, 2024
78 of 79 checks passed
@jed326 jed326 deleted the backport-12697 branch August 7, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants