Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump netty from 4.1.107.Final to 4.1.108.Final #12924

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Mar 26, 2024

Description

Bump netty from 4.1.107.Final to 4.1.108.Final

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for cb0b0b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 26, 2024

Compatibility status:

Checks if related components are compatible with change 7a717b0

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 7a717b0: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7a717b0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Mar 26, 2024

❌ Gradle check result for 7a717b0: FAILURE

Mar 27, 2024 12:50:02 AM com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler uncaughtException
WARNING: Uncaught exception in thread: Thread[#621,opensearch[AbstractAsyncTaskTests][generic][T#2],5,TGRP-AbstractAsyncTaskTests]
java.lang.AssertionError: interrupted
	at __randomizedtesting.SeedInfo.seed([1AE4181479361976]:0)
	at org.junit.Assert.fail(Assert.java:89)
	at org.opensearch.common.util.concurrent.AbstractAsyncTaskTests$1.runInternal(AbstractAsyncTaskTests.java:85)
	at org.opensearch.common.util.concurrent.AbstractAsyncTask.run(AbstractAsyncTask.java:159)
	at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:854)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

This is new, looking if Netty is the cause

Copy link
Contributor

❕ Gradle check result for 7a717b0: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

✅ Gradle check result for 7a717b0: SUCCESS

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.49%. Comparing base (b15cb0c) to head (7a717b0).
Report is 94 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12924      +/-   ##
============================================
+ Coverage     71.42%   71.49%   +0.07%     
- Complexity    59978    60305     +327     
============================================
  Files          4985     5015      +30     
  Lines        282275   283799    +1524     
  Branches      40946    41130     +184     
============================================
+ Hits         201603   202900    +1297     
- Misses        63999    64090      +91     
- Partials      16673    16809     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit a4d6d55 into opensearch-project:main Mar 26, 2024
50 of 56 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Mar 26, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12924-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a4d6d55ec78cde53c80c3e0626904d594bd518db
# Push it to GitHub
git push --set-upstream origin backport/backport-12924-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12924-to-2.x.

reta added a commit to reta/OpenSearch that referenced this pull request Mar 26, 2024
reta added a commit to reta/OpenSearch that referenced this pull request Mar 26, 2024
reta added a commit to reta/OpenSearch that referenced this pull request Mar 26, 2024
reta added a commit to reta/OpenSearch that referenced this pull request Mar 26, 2024
)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit a4d6d55)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit to reta/OpenSearch that referenced this pull request Mar 26, 2024
)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit a4d6d55)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit that referenced this pull request Mar 26, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit a4d6d55)
reta added a commit that referenced this pull request Mar 26, 2024
(cherry picked from commit a4d6d55)

Signed-off-by: Andriy Redko <[email protected]>
reta added a commit that referenced this pull request Mar 26, 2024
(cherry picked from commit a4d6d55)

Signed-off-by: Andriy Redko <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants